From: Alexei Starovoitov <ast@plumgrid.com>
To: Kaixu Xia <xiakaixu@huawei.com>,
davem@davemloft.net, acme@kernel.org, mingo@redhat.com,
a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com,
jolsa@kernel.org, daniel@iogearbox.net
Cc: wangnan0@huawei.com, linux-kernel@vger.kernel.org,
pi3orama@163.com, hekuang@huawei.com, netdev@vger.kernel.org
Subject: Re: [PATCH v5 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter
Date: Fri, 31 Jul 2015 09:33:29 -0700 [thread overview]
Message-ID: <55BBA359.2060601@plumgrid.com> (raw)
In-Reply-To: <1438343970-11974-1-git-send-email-xiakaixu@huawei.com>
On 7/31/15 4:59 AM, Kaixu Xia wrote:
> changes in V5:
> - move struct fd_array_map_ops* fd_ops to bpf_map;
> - move array perf event decrement refcnt function to
> map_free;
> - fix the NULL ptr of perf_event_get();
> - move bpf_perf_event_read() to kernel/bpf/bpf_trace.c;
> - get rid of the remaining struct bpf_prog;
> - move the unnecessay cast on void *;
overall looks good. few nits here and there...
With amount of changes to bpf core in patch 1 it definitely
needs to go via net-next, otherwise merge window conflicts
will be nasty.
Ingo, Peter, could you please review perf bits in patches 2 and 3,
so we can take the whole set via net-next.
Thanks!
prev parent reply other threads:[~2015-07-31 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 11:59 [PATCH v5 0/4] bpf: Introduce the new ability of eBPF programs to access hardware PMU counter Kaixu Xia
2015-07-31 11:59 ` [PATCH v5 1/4] bpf: Make the bpf_prog_array_map more generic Kaixu Xia
2015-07-31 16:36 ` Alexei Starovoitov
2015-07-31 11:59 ` [PATCH v5 2/4] bpf: Add new bpf map type to store the pointer to struct perf_event Kaixu Xia
2015-07-31 16:39 ` Alexei Starovoitov
2015-07-31 11:59 ` [PATCH v5 3/4] bpf: Implement function bpf_perf_event_read() that get the selected hardware PMU conuter Kaixu Xia
2015-07-31 16:43 ` Alexei Starovoitov
2015-07-31 11:59 ` [PATCH v5 4/4] samples/bpf: example of get selected PMU counter value Kaixu Xia
2015-07-31 16:33 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BBA359.2060601@plumgrid.com \
--to=ast@plumgrid.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).