From: Ivan Vecera <ivecera@redhat.com>
To: Corcodel Marian <corcodel.marian@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] r8169:Fill with zero Tx descriptors
Date: Wed, 5 Aug 2015 15:42:36 +0200 [thread overview]
Message-ID: <55C212CC.8060305@redhat.com> (raw)
In-Reply-To: <1438771604-17621-1-git-send-email-corcodel.marian@gmail.com>
On 5.8.2015 12:46, Corcodel Marian wrote:
> This patch fill with zero Tx descriptors before use.Is only
> on part by more patches but is critical.(critical)
>
>
> Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 3df51fa..bf78f94 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7589,7 +7589,7 @@ static int rtl_open(struct net_device *dev)
> * Rx and Tx descriptors needs 256 bytes alignment.
> * dma_alloc_coherent provides more.
> */
> - tp->TxDescArray = dma_alloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
> + tp->TxDescArray = dma_zalloc_coherent(&pdev->dev, R8169_TX_RING_BYTES,
> &tp->TxPhyAddr, GFP_KERNEL);
> if (!tp->TxDescArray)
> goto err_pm_runtime_put;
>
Why? Why is zero-filling of tx-ring critical???
Ivan
prev parent reply other threads:[~2015-08-05 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 10:46 [PATCH] r8169:Fill with zero Tx descriptors Corcodel Marian
2015-08-05 12:57 ` Sergei Shtylyov
2015-08-05 13:42 ` Ivan Vecera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C212CC.8060305@redhat.com \
--to=ivecera@redhat.com \
--cc=corcodel.marian@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).