From: David Vrabel <david.vrabel@citrix.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Ian Campbell <ian.campbell@citrix.com>
Cc: <netdev@vger.kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xen.org>
Subject: Re: [Xen-devel] printk from softirq on xen: hard lockup
Date: Thu, 6 Aug 2015 17:10:17 +0100 [thread overview]
Message-ID: <55C386E9.6060806@citrix.com> (raw)
In-Reply-To: <CAHmME9r1Ugk65OWgATh-aqW9s9QDpC8zckgP180vTAFj32wP9w@mail.gmail.com>
On 06/08/15 16:58, Jason A. Donenfeld wrote:
> On Thu, Aug 6, 2015 at 12:02 PM, David Vrabel <david.vrabel@citrix.com> wrote:
>> Linux PV guests must use the "Xen PV" APIC driver. You need to
>> investigate why your PV guest is not using this (although I'm surprised
>> it works at all with the wrong one).
>
> Actually it appears this PV Guest is using the "flat" APIC driver
> instead of the Xen APIC driver.
>
> But upon further investigation into why:
>
> arch/x86/xen/Makefile:
> obj-$(CONFIG_XEN_DOM0) += apic.o vga.o
>
> It would appear that only dom0 gets to use the Xen APIC driver.
>
> What gives?
Looks like the Makefile is wrong.
Try this:
8<------------------
x86/xen: build "Xen PV" APIC driver for domU as well
A PV domU also needs the Xen PV APIC driver but it was only built for
CONFIG_XEN_DOM0=y.
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Cc: <stable@vger.kernel.org>
---
arch/x86/xen/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 7322755..4b6e29a 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -13,13 +13,13 @@ CFLAGS_mmu.o := $(nostackp)
obj-y := enlighten.o setup.o multicalls.o mmu.o irq.o \
time.o xen-asm.o xen-asm_$(BITS).o \
grant-table.o suspend.o platform-pci-unplug.o \
- p2m.o
+ p2m.o apic.o
obj-$(CONFIG_EVENT_TRACING) += trace.o
obj-$(CONFIG_SMP) += smp.o
obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o
obj-$(CONFIG_XEN_DEBUG_FS) += debugfs.o
-obj-$(CONFIG_XEN_DOM0) += apic.o vga.o
+obj-$(CONFIG_XEN_DOM0) += vga.o
obj-$(CONFIG_SWIOTLB_XEN) += pci-swiotlb-xen.o
obj-$(CONFIG_XEN_EFI) += efi.o
--
2.1.4
next prev parent reply other threads:[~2015-08-06 16:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 16:41 printk from softirq on xen: hard lockup Jason A. Donenfeld
2015-08-04 17:12 ` [Xen-devel] " David Vrabel
2015-08-04 17:45 ` Jason A. Donenfeld
2015-08-04 23:01 ` [Xen-devel] " Jason A. Donenfeld
2015-08-06 10:02 ` David Vrabel
2015-08-06 15:58 ` Jason A. Donenfeld
2015-08-06 16:10 ` David Vrabel [this message]
2015-08-06 16:21 ` Jason A. Donenfeld
2015-08-06 16:29 ` [PATCH] xen-apic: Enable on domU as well Jason A. Donenfeld
2015-08-06 16:37 ` [PATCH v2] " Jason A. Donenfeld
2015-08-07 14:23 ` [Xen-devel] " Konrad Rzeszutek Wilk
2015-08-07 14:37 ` Jason A. Donenfeld
2015-08-10 13:40 ` [PATCH v3] " Jason A. Donenfeld
2015-08-10 13:41 ` David Vrabel
2015-08-10 13:44 ` Jason A. Donenfeld
2015-08-11 10:46 ` [Xen-devel] " David Vrabel
2015-08-05 16:37 ` [Xen-devel] printk from softirq on xen: hard lockup Jason A. Donenfeld
2015-08-06 8:22 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C386E9.6060806@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Jason@zx2c4.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).