From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, linux@roeck-us.net, andrew@lunn.ch,
sfeldma@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects
Date: Tue, 11 Aug 2015 11:03:35 -0700 [thread overview]
Message-ID: <55CA38F7.4010105@gmail.com> (raw)
In-Reply-To: <20150811.103817.787813230853567028.davem@davemloft.net>
On 11/08/15 10:38, David Miller wrote:
> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> Date: Tue, 11 Aug 2015 12:25:06 -0400 (EDT)
>
>> I can work on fixup patches to restore v3 changes on top of v2, but this
>> won't fix the bisectability issue.
>>
>> Instead of fixing individual portions, reverting the merge commit
>> f1d5ca4: "Merge branch 'mv88e6xxx-switchdev-fdb'" would undo all the v2
>> series at once, then v3 can be merged on top of it.
>>
>> Can you consider this as an option?
>
> Nothing will fix bisectability, so don't try.
>
> Reverting an entire series when you have the fix available
> already is excessive.
>
> So as I have already asked you, send a relative fixup to clear
> up this situation.
What if the fix is to actually not break bisectability? Put differently,
my question is how do you value not rewriting history vs. breaking
bisectability (by accident of course)?
--
Florian
next prev parent reply other threads:[~2015-08-11 18:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 5:44 [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 1/7] net: switchdev: change fdb addr for a byte array Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 2/7] net: switchdev: support static FDB addresses Vivien Didelot
2015-08-06 6:28 ` Scott Feldman
2015-08-06 14:19 ` Vivien Didelot
2015-08-06 16:37 ` Scott Feldman
2015-08-06 5:44 ` [PATCH net-next v2 3/7] net: dsa: add support for switchdev FDB objects Vivien Didelot
2015-08-06 14:04 ` Andrew Lunn
2015-08-06 14:52 ` Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 4/7] net: dsa: mv88e6xxx: extend fid mask Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 5/7] net: dsa: mv88e6xxx: rename ATU MAC accessors Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 6/7] net: dsa: mv88e6xxx: rework FDB getnext operation Vivien Didelot
2015-08-06 5:44 ` [PATCH net-next v2 7/7] net: dsa: mv88e6xxx: rework FDB add/del operations Vivien Didelot
2015-08-10 5:48 ` [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects David Miller
2015-08-10 13:39 ` Vivien Didelot
2015-08-11 16:25 ` Vivien Didelot
2015-08-11 17:38 ` David Miller
2015-08-11 18:03 ` Florian Fainelli [this message]
2015-08-11 18:07 ` David Miller
2015-08-11 18:18 ` Vivien Didelot
2015-08-11 18:52 ` David Miller
2015-08-11 19:00 ` David Miller
2015-08-11 19:05 ` David Miller
2015-08-11 20:10 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CA38F7.4010105@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).