From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next v2 0/7] net: dsa: mv88e6xxx: support switchdev FDB objects Date: Tue, 11 Aug 2015 11:03:35 -0700 Message-ID: <55CA38F7.4010105@gmail.com> References: <20150809.224822.1627697290087246344.davem@davemloft.net> <20150810133924.GA10802@ketchup.touchtunes.com> <1065657734.1253359.1439310306115.JavaMail.zimbra@savoirfairelinux.com> <20150811.103817.787813230853567028.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, linux@roeck-us.net, andrew@lunn.ch, sfeldma@gmail.com, jiri@resnulli.us To: David Miller , vivien.didelot@savoirfairelinux.com Return-path: Received: from mail-pd0-f180.google.com ([209.85.192.180]:33116 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751841AbbHKSFt (ORCPT ); Tue, 11 Aug 2015 14:05:49 -0400 In-Reply-To: <20150811.103817.787813230853567028.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On 11/08/15 10:38, David Miller wrote: > From: Vivien Didelot > Date: Tue, 11 Aug 2015 12:25:06 -0400 (EDT) > >> I can work on fixup patches to restore v3 changes on top of v2, but this >> won't fix the bisectability issue. >> >> Instead of fixing individual portions, reverting the merge commit >> f1d5ca4: "Merge branch 'mv88e6xxx-switchdev-fdb'" would undo all the v2 >> series at once, then v3 can be merged on top of it. >> >> Can you consider this as an option? > > Nothing will fix bisectability, so don't try. > > Reverting an entire series when you have the fix available > already is excessive. > > So as I have already asked you, send a relative fixup to clear > up this situation. What if the fix is to actually not break bisectability? Put differently, my question is how do you value not rewriting history vs. breaking bisectability (by accident of course)? -- Florian