From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki Subject: Re: [PATCH v2 net-next 13/13] ipv6: route: per route IP tunnel metadata via lightweight tunnel Date: Wed, 19 Aug 2015 19:27:22 +0900 Message-ID: <55D45A0A.7010100@miraclelinux.com> References: <0694438feae2730b0bd3354b5e977bc9d6a5a192.1439978875.git.jbenc@redhat.com> <55D457B1.2080105@miraclelinux.com> <20150819122034.5d904d8b@griffin> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: hideaki.yoshifuji@miraclelinux.com, netdev@vger.kernel.org, Thomas Graf To: Jiri Benc Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:36505 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751871AbbHSK1Z (ORCPT ); Wed, 19 Aug 2015 06:27:25 -0400 Received: by pawq9 with SMTP id q9so275367paw.3 for ; Wed, 19 Aug 2015 03:27:25 -0700 (PDT) In-Reply-To: <20150819122034.5d904d8b@griffin> Sender: netdev-owner@vger.kernel.org List-ID: Jiri Benc wrote: > On Wed, 19 Aug 2015 19:17:21 +0900, YOSHIFUJI Hideaki wrote: >> Jiri Benc wrote: >>> Allow specification of per route IP tunnel instructions also for IPv6. >>> This complements commit 3093fbe7ff4b ("route: Per route IP tunnel metadata >>> via lightweight tunnel"). >>> >>> Signed-off-by: Jiri Benc >>> --- >>> include/uapi/linux/lwtunnel.h | 16 +++++++ >>> net/ipv4/ip_tunnel_core.c | 102 ++++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 118 insertions(+) >>> >>> diff --git a/include/uapi/linux/lwtunnel.h b/include/uapi/linux/lwtunnel.h >>> index aa84ca396bcb..32a149571417 100644 >>> --- a/include/uapi/linux/lwtunnel.h >>> +++ b/include/uapi/linux/lwtunnel.h >>> @@ -7,6 +7,7 @@ enum lwtunnel_encap_types { >>> LWTUNNEL_ENCAP_NONE, >>> LWTUNNEL_ENCAP_MPLS, >>> LWTUNNEL_ENCAP_IP, >>> + LWTUNNEL_ENCAP_IP6, >>> LWTUNNEL_ENCAP_ILA, >>> __LWTUNNEL_ENCAP_MAX, >>> }; >> >> Please do not add new one in the middle of enums. > > You're right generally. But this one should be okay and I did this > deliberately: the patch adding LWTUNNEL_ENCAP_ILA was merged two days > ago, is in net-next only, is not used by anything in user space yet. > And I think it's better to have LWTUNNEL_ENCAP_IP and > LWTUNNEL_ENCAP_IP6 without anything in between. I do think you should have some descriptions. -- Hideaki Yoshifuji Technical Division, MIRACLE LINUX CORPORATION