From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 00/18] Export SPI and OF module aliases in missing drivers Date: Thu, 20 Aug 2015 23:50:50 +0200 Message-ID: <55D64BBA.7070802@osg.samsung.com> References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <20150820211152.GI74600@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-fbdev@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, Krzysztof Kozlowski , Adrian Hunter , Andrzej Hajda , netdev@vger.kernel.org, linux-mtd@lists.infradead.org, Peter Meerwald , Lee Jones , Aloisio Almeida Jr , devel@driverdev.osuosl.org, Lars-Peter Clausen , Stephen Warren , Samuel Ortiz , =?UTF-8?Q?S=c3=b8ren_Andersen?= , Andrea Galbusera , Antonio Borneo , Tomi Valkeinen , Ulf Hansson , Jean-Christophe Plagniol-Villard , linux-media@vger.kernel.org, Michael Hennerich , Mauro To: Brian Norris Return-path: In-Reply-To: <20150820211152.GI74600@google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org Hello Brian, On 08/20/2015 11:11 PM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote: >> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches > > ^^^ I'm dying to know how this sentence ends :) > Sigh, I did some last minute restructuring of the cover letter and seems I missed a sentence. I meant to said: "and patches #9 to #17 solves c)." >> Patch #18 changes the logic of spi_uevent() to report an OF modalias if >> the device was registered using OF. But this patch is included in the >> series only as an RFC for illustration purposes since changing that >> without first applying all the other patches in this series, will break >> module autoloading for the drivers of devices registered using OF but >> that lacks an of_match_table. I'll repost patch #18 once all the patches >> in this series have landed. > > On a more productive note, the patches I've looked at look good to me. > The missing aliases are a problem enough that should be fixed (i.e., > part (b)). I'll leave the SPI framework changes to others to comment on. > Great, thanks a lot for your feedback. > Brian > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America