From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH v2] net: bcmgenet: fix uncleaned dma flags Date: Fri, 21 Aug 2015 11:26:00 -0700 Message-ID: <55D76D38.9090500@gmail.com> References: <1440119306-6789-1-git-send-email-jaedon.shin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Jaedon Shin , David Miller , Petri Gynther , netdev@vger.kernel.org Return-path: Received: from mail-pd0-f176.google.com ([209.85.192.176]:34577 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbbHUS2Y (ORCPT ); Fri, 21 Aug 2015 14:28:24 -0400 Received: by pdbfa8 with SMTP id fa8so29281620pdb.1 for ; Fri, 21 Aug 2015 11:28:24 -0700 (PDT) In-Reply-To: <1440119306-6789-1-git-send-email-jaedon.shin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 20/08/15 18:08, Jaedon Shin wrote: > Clean the dma flags of multiq ring buffer int the interface stop > process. This patch fixes that the genet is not running while the > interface is re-enabled. > > $ ifup eth0 - running after booting > $ ifdown eth0 > $ ifup eth0 - not running and occur tx_timeout > > The bcmgenet_dma_disable() in bcmgenet_open() do clean ring16 dma flag > only. If the genet has multiq, the dma register is not cleaned. and > bcmgenet_init_dma() is not done correctly. in case > GENET_V2(tx_queues=4), tdma_ctrl has 0x1e after running > bcmgenet_dma_disable(). > > Signed-off-by: Jaedon Shin Reviewed-by: Florian Fainelli Thanks! -- Florian