From: Florian Fainelli <f.fainelli@gmail.com>
To: David Daney <ddaney.cavm@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Cc: David Daney <david.daney@cavium.com>,
Lennert Buytenhek <buytenh@wantstofly.org>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.
Date: Fri, 21 Aug 2015 16:59:45 -0700 [thread overview]
Message-ID: <55D7BB71.6020601@gmail.com> (raw)
In-Reply-To: <1440198963-20080-1-git-send-email-ddaney.cavm@gmail.com>
On 21/08/15 16:16, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
>
> commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent")
> changed the parent of PHY devices from the bus to the bus parent.
>
> Then, commit 4dea547fef1b ("phylib: rework to prepare for OF
> registration of PHYs") moved the code into phy_device.c
>
> At this point, it is somewhat unclear why the change was seen as
> necessary. But, when we look at the device model tree in
> /sys/devices, it is clearly incorrect. The PHYs should be children of
> their MDIO bus.
>
> Change the PHY's parent device to be the MDIO bus device.
>
> Cc: Lennert Buytenhek <buytenh@wantstofly.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Signed-off-by: David Daney <david.daney@cavium.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2015-08-22 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 23:16 [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent David Daney
2015-08-21 23:59 ` Florian Fainelli [this message]
2015-08-25 18:31 ` David Miller
2015-11-19 20:51 ` Sergei Shtylyov
2015-11-19 21:06 ` Andrew Lunn
2015-11-19 21:33 ` Sergei Shtylyov
2015-11-19 23:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D7BB71.6020601@gmail.com \
--to=f.fainelli@gmail.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).