[PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

[PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

[Simon Horman]

From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

Currently the renesas ethernet driver directory is compiled if SH_ETH is
configured rather than NET_VENDOR_RENESAS. Although incorrect that was
quite harmless as until recently as SH_ETH configured the only driver in
the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB
driver proper") the renesas directory includes another driver, configured
by RAVB, and it makes little sense for it to have a hidden dependency on
SH_ETH.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
[horms: rewrote changelog]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/net/ethernet/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Reposted with net-next prefix.

diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
index f42177b11723..ddfc808110a1 100644
--- a/drivers/net/ethernet/Makefile
+++ b/drivers/net/ethernet/Makefile
@@ -65,7 +65,7 @@ obj-$(CONFIG_NET_VENDOR_PASEMI) += pasemi/
 obj-$(CONFIG_NET_VENDOR_QLOGIC) += qlogic/
 obj-$(CONFIG_NET_VENDOR_QUALCOMM) += qualcomm/
 obj-$(CONFIG_NET_VENDOR_REALTEK) += realtek/
-obj-$(CONFIG_SH_ETH) += renesas/
+obj-$(CONFIG_NET_VENDOR_RENESAS) += renesas/
 obj-$(CONFIG_NET_VENDOR_RDC) += rdc/
 obj-$(CONFIG_NET_VENDOR_ROCKER) += rocker/
 obj-$(CONFIG_NET_VENDOR_SAMSUNG) += samsung/
-- 
2.1.4

Re: [PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

[Sergei Shtylyov]

On 8/25/2015 11:03 AM, Simon Horman wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> Currently the renesas ethernet driver directory is compiled if SH_ETH is
> configured rather than NET_VENDOR_RENESAS. Although incorrect that was
> quite harmless as until recently as SH_ETH configured the only driver in
> the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB
> driver proper") the renesas directory includes another driver, configured
> by RAVB, and it makes little sense for it to have a hidden dependency on
> SH_ETH.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> [horms: rewrote changelog]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

    Sorry about missing that when submitting the AVB driver.

MBR, Sergei

Re: [PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

[Sergei Shtylyov]

On 08/25/2015 11:34 AM, Sergei Shtylyov wrote:

>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>
>> Currently the renesas ethernet driver directory is compiled if SH_ETH is
>> configured rather than NET_VENDOR_RENESAS. Although incorrect that was
>> quite harmless as until recently as SH_ETH configured the only driver in
>> the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB
>> driver proper") the renesas directory includes another driver, configured
>> by RAVB, and it makes little sense for it to have a hidden dependency on
>> SH_ETH.
>>
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> [horms: rewrote changelog]
>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
>     Sorry about missing that when submitting the AVB driver.

    BTW, why against net-next? I consider this a fix.

MBR, Sergei

Re: [PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

[Simon Horman]

On Wed, Aug 26, 2015 at 12:15:57AM +0300, Sergei Shtylyov wrote:
> On 08/25/2015 11:34 AM, Sergei Shtylyov wrote:
> 
> >>From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >>
> >>Currently the renesas ethernet driver directory is compiled if SH_ETH is
> >>configured rather than NET_VENDOR_RENESAS. Although incorrect that was
> >>quite harmless as until recently as SH_ETH configured the only driver in
> >>the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB
> >>driver proper") the renesas directory includes another driver, configured
> >>by RAVB, and it makes little sense for it to have a hidden dependency on
> >>SH_ETH.
> >>
> >>Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >>[horms: rewrote changelog]
> >>Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> >    Sorry about missing that when submitting the AVB driver.
> 
>    BTW, why against net-next? I consider this a fix.

I wasn't sure which way to go and decided to err on the side of caution with a
net-next submission. I have no objections to it being considered for next.

Re: [PATCH repost net-next] net: compile renesas directory if NET_VENDOR_RENESAS is configured

[David Miller]

From: Simon Horman <horms@verge.net.au>
Date: Wed, 26 Aug 2015 08:55:39 +1000

> On Wed, Aug 26, 2015 at 12:15:57AM +0300, Sergei Shtylyov wrote:
>> On 08/25/2015 11:34 AM, Sergei Shtylyov wrote:
>> 
>> >>From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> >>
>> >>Currently the renesas ethernet driver directory is compiled if SH_ETH is
>> >>configured rather than NET_VENDOR_RENESAS. Although incorrect that was
>> >>quite harmless as until recently as SH_ETH configured the only driver in
>> >>the renesas directory. However, as of c156633f1353 ("Renesas Ethernet AVB
>> >>driver proper") the renesas directory includes another driver, configured
>> >>by RAVB, and it makes little sense for it to have a hidden dependency on
>> >>SH_ETH.
>> >>
>> >>Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> >>[horms: rewrote changelog]
>> >>Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> >
>> >    Sorry about missing that when submitting the AVB driver.
>> 
>>    BTW, why against net-next? I consider this a fix.
> 
> I wasn't sure which way to go and decided to err on the side of caution with a
> net-next submission. I have no objections to it being considered for next.

I'll put it in the 'net' tree.

Applied, thanks.