From: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net, jiri@resnulli.us,
edumazet@google.com, hannes@stressinduktion.org,
tom@herbertland.com, azhou@nicira.com, ebiederm@xmission.com,
ipm@chirality.org.uk, nicolas.dichtel@6wind.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
anton@au1.ibm.com, nacc@linux.vnet.ibm.com,
srikar@linux.vnet.ibm.com
Subject: Re: [PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once
Date: Wed, 26 Aug 2015 16:34:29 +0530 [thread overview]
Message-ID: <55DD9D3D.6050003@linux.vnet.ibm.com> (raw)
In-Reply-To: <1440518424.8932.19.camel@edumazet-glaptop2.roam.corp.google.com>
On 08/25/2015 09:30 PM, Eric Dumazet wrote:
> On Tue, 2015-08-25 at 21:17 +0530, Raghavendra K T wrote:
>> On 08/25/2015 07:58 PM, Eric Dumazet wrote:
>
>>>
>>>
>>> This is a great idea, but kcalloc()/kmalloc() can fail and you'll crash
>>> the whole kernel at this point.
>>>
>>
>> Good catch, and my bad. Though system is in bad memory condition,
>> since fill_stat is not critical for the system do you think silently
>> returning from here is a good idea?
>> or do you think we should handle with -ENOMEM way up.?
>
> Hmm... presumably these 288 bytes could be allocated in
> inet6_fill_ifla6_attrs() stack frame.
Correct, since we need to allocate for IPSTATS_MIB_MAX, we could do
this in even snmp6_fill_stats() stack frame.
next prev parent reply other threads:[~2015-08-26 11:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 7:54 [PATCH RFC 0/2] Optimize the snmp stat aggregation for large cpus Raghavendra K T
2015-08-25 7:54 ` [PATCH RFC 1/2] net: Introduce helper functions to get the per cpu data Raghavendra K T
2015-08-25 7:54 ` [PATCH RFC 2/2] net: Optimize snmp stat aggregation by walking all the percpu data at once Raghavendra K T
2015-08-25 14:28 ` Eric Dumazet
2015-08-25 15:47 ` Raghavendra K T
2015-08-25 16:00 ` Eric Dumazet
2015-08-25 16:06 ` Raghavendra K T
2015-08-26 11:04 ` Raghavendra K T [this message]
2015-08-25 14:33 ` [PATCH RFC 0/2] Optimize the snmp stat aggregation for large cpus Eric Dumazet
2015-08-25 15:55 ` Raghavendra K T
2015-08-25 23:07 ` David Miller
2015-08-26 10:25 ` Raghavendra K T
2015-08-26 14:09 ` Eric Dumazet
2015-08-26 14:30 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DD9D3D.6050003@linux.vnet.ibm.com \
--to=raghavendra.kt@linux.vnet.ibm.com \
--cc=anton@au1.ibm.com \
--cc=azhou@nicira.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=ipm@chirality.org.uk \
--cc=jiri@resnulli.us \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=nacc@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=tom@herbertland.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).