From: Florian Fainelli <f.fainelli@gmail.com>
To: Mark Salter <msalter@redhat.com>, David Miller <davem@davemloft.net>
Cc: David Daney <ddaney.cavm@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
buytenh@wantstofly.org, grant.likely@secretlab.ca
Subject: Re: [PATCH] phylib: fix device deletion order in mdiobus_unregister()
Date: Tue, 1 Sep 2015 06:55:02 -0700 [thread overview]
Message-ID: <55E5AE36.7030906@gmail.com> (raw)
In-Reply-To: <1441114565-2340-1-git-send-email-msalter@redhat.com>
Le 09/01/15 06:36, Mark Salter a écrit :
> commit 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
> the bus' parent.") uncovered a problem in mdiobus_unregister() which
> leads to this warning when I reboot an APM Mustang (arm64) platform:
>
> WARNING: CPU: 7 PID: 4239 at fs/sysfs/group.c:224 sysfs_remove_group+0xa0/0xa4()
> sysfs group fffffe0000e07a10 not found for kobject 'xgene-mii-eth0:03'
> ...
> CPU: 7 PID: 4239 Comm: reboot Tainted: G E 4.2.0-0.18.el7.test15.aarch64 #1
> Hardware name: AppliedMicro Mustang/Mustang, BIOS 1.1.0 Aug 26 2015
> Call Trace:
> [<fffffe000009739c>] dump_backtrace+0x0/0x170
> [<fffffe000009752c>] show_stack+0x20/0x2c
> [<fffffe00007436f0>] dump_stack+0x78/0x9c
> [<fffffe00000c2cb4>] warn_slowpath_common+0xa0/0xd8
> [<fffffe00000c2d60>] warn_slowpath_fmt+0x74/0x88
> [<fffffe0000293d3c>] sysfs_remove_group+0x9c/0xa4
> [<fffffe00004a8bac>] dpm_sysfs_remove+0x5c/0x70
> [<fffffe000049b388>] device_del+0x44/0x208
> [<fffffe000049b578>] device_unregister+0x2c/0x7c
> [<fffffe000050dc68>] mdiobus_unregister+0x48/0x94
> [<fffffe000052afd0>] xgene_enet_mdio_remove+0x28/0x44
> [<fffffe000052d3f0>] xgene_enet_remove+0xd0/0xd8
> [<fffffe000052d424>] xgene_enet_shutdown+0x2c/0x3c
> [<fffffe00004a204c>] platform_drv_shutdown+0x24/0x40
> [<fffffe000049d4f4>] device_shutdown+0xf0/0x1b4
> [<fffffe00000e31ec>] kernel_restart_prepare+0x40/0x4c
> [<fffffe00000e32f8>] kernel_restart+0x1c/0x80
> [<fffffe00000e3670>] SyS_reboot+0x17c/0x250
>
> The problem is that mdiobus_unregister() deletes the bus device before
> unregistering the phy devices on the bus. This wasn't a problem before
> because the phys were not children of the bus:
>
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0:03
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0
>
> But now that they are:
>
> /sys/devices/platform/APMC0D05:00/net/eth0/xgene-mii-eth0/xgene-mii-eth0:03
>
> when mdiobus_unregister deletes the bus device, the phy subdirs are
> removed from sysfs also. So when the phys are unregistered afterward,
> we get the warning. This patch changes the order so that phys are
> unregistered before the bus device is deleted.
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
Fixes: 8b63ec1837fa ("phylib: Make PHYs children of their MDIO bus, not
the bus' parent.")
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks!
--
Florian
next prev parent reply other threads:[~2015-09-01 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 13:36 [PATCH] phylib: fix device deletion order in mdiobus_unregister() Mark Salter
2015-09-01 13:55 ` Florian Fainelli [this message]
2015-09-01 14:07 ` Mark Langsdorf
2015-09-01 22:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E5AE36.7030906@gmail.com \
--to=f.fainelli@gmail.com \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=ddaney.cavm@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).