From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>, netdev@vger.kernel.org
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
arc-linux-dev@synopsys.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] stmmac: fix check for phydev being open
Date: Mon, 7 Sep 2015 21:19:58 +0300 [thread overview]
Message-ID: <55EDD54E.7030205@cogentembedded.com> (raw)
In-Reply-To: <1441649709-12325-1-git-send-email-abrodkin@synopsys.com>
Hello.
On 09/07/2015 09:15 PM, Alexey Brodkin wrote:
> Current implementation via IS_ERR(phydev) may make no sense because
> of_phy_attach() returns NULL on failure instead of error value.
> Still for checking result of phy_connect() IS_ERR() is useful.
> So adding explicit check for NULL.
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: arc-linux-dev@synopsys.com
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 864b476..ad2ce3e 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -837,7 +837,7 @@ static int stmmac_init_phy(struct net_device *dev)
> interface);
> }
>
> - if (IS_ERR(phydev)) {
> + if (!phydev || IS_ERR(phydev)) {
There's IS_ERR_OR_NULL().
WBR, Sergei
prev parent reply other threads:[~2015-09-07 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 18:15 [PATCH] stmmac: fix check for phydev being open Alexey Brodkin
2015-09-07 18:19 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EDD54E.7030205@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=arc-linux-dev@synopsys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).