From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>, netdev@vger.kernel.org
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] stmmac: fix check for phydev being open
Date: Tue, 8 Sep 2015 00:24:30 +0300 [thread overview]
Message-ID: <55EE008E.6040405@cogentembedded.com> (raw)
In-Reply-To: <1441659019-25522-1-git-send-email-abrodkin@synopsys.com>
On 09/07/2015 11:50 PM, Alexey Brodkin wrote:
> Current implementation via IS_ERR(phydev) may make no sense because
> of_phy_attach() returns NULL on failure instead of error value.
Not of_phy_connect()?
> Still for checking result of phy_connect() IS_ERR() is useful.
>
> To address both situations we use combined IS_ERR_OR_NULL() check.
>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Cc: David Miller <davem@davemloft.net>
> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
MBR, Sergei
next prev parent reply other threads:[~2015-09-07 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-07 20:50 [PATCH v2] stmmac: fix check for phydev being open Alexey Brodkin
2015-09-07 20:53 ` Sergei Shtylyov
2015-09-07 21:08 ` Alexey Brodkin
2015-09-07 21:24 ` Sergei Shtylyov [this message]
2015-09-07 21:26 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EE008E.6040405@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).