From: Petr Cvek <petr.cvek@tul.cz>
To: Robert Jarzmik <robert.jarzmik@free.fr>,
Samuel Ortiz <samuel@sortiz.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel
Date: Tue, 8 Sep 2015 22:24:09 +0200 [thread overview]
Message-ID: <55EF43E9.2040000@tul.cz> (raw)
In-Reply-To: <1441261251-19548-3-git-send-email-robert.jarzmik@free.fr>
Dne 3.9.2015 v 08:20 Robert Jarzmik napsal(a):
> Convert the pxa IRDA driver to readl and writel primitives, and remove
> another set of direct registers access. This leaves only the DMA
> registers access, which will be dealt with dmaengine conversion.
Test on magician (nonvanilla, but there should not be any collision).
>
> - err = request_mem_region(__PREG(STUART), 0x24, "IrDA") ? 0 : -EBUSY;
> - if (err)
> - goto err_mem_1;
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + ficp = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(ficp)) {
> + dev_err(&pdev->dev, "resource ficp not defined\n");
Fails around here with:
[ 4245.368764] pxa2xx-ir pxa2xx-ir: invalid resource
[ 4245.369191] pxa2xx-ir pxa2xx-ir: resource ficp not defined
[ 4245.369364] pxa2xx-ir: probe of pxa2xx-ir failed with error -22
Did you defined resources somewhere? Actual resources are in "pxa_ir_resources" variable at:
http://lxr.free-electrons.com/source/arch/arm/mach-pxa/devices.c#L386
or this pdata should be moved into specific machine files?
Cheers,
Petr
next prev parent reply other threads:[~2015-09-08 20:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 6:20 [PATCH 0/3] net: irda: pxaficp_ir: dmaengine conversion Robert Jarzmik
2015-09-03 6:20 ` [PATCH 1/3] net: irda: pxaficp_ir: use sched_clock() for time management Robert Jarzmik
2015-09-03 6:20 ` [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel Robert Jarzmik
2015-09-08 20:24 ` Petr Cvek [this message]
2015-09-09 1:23 ` Petr Cvek
2015-09-09 6:25 ` Robert Jarzmik
2015-09-10 6:14 ` Petr Cvek
2015-09-10 11:14 ` Robert Jarzmik
2015-09-11 1:52 ` Petr Cvek
2015-09-11 6:18 ` Robert Jarzmik
2015-09-12 4:18 ` Petr Cvek
2015-09-12 11:03 ` Robert Jarzmik
2015-09-13 2:47 ` Petr Cvek
2015-09-03 6:20 ` [PATCH 3/3] net: irda: pxaficp_ir: dmaengine conversion Robert Jarzmik
2015-09-07 4:16 ` [PATCH 0/3] " Petr Cvek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EF43E9.2040000@tul.cz \
--to=petr.cvek@tul.cz \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).