From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH] ipv6: fix ifnullfree.cocci warnings Date: Wed, 09 Sep 2015 22:08:52 -0700 Message-ID: <55F11064.6090309@cumulusnetworks.com> References: <201509100609.fhjHrskx%fengguang.wu@intel.com> <20150909225712.GA6796@lkp-nex05> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kbuild-all@01.org, Nikolay Aleksandrov , netdev@vger.kernel.org, Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , linux-kernel@vger.kernel.org To: kbuild test robot Return-path: In-Reply-To: <20150909225712.GA6796@lkp-nex05> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 9/9/15, 3:57 PM, kbuild test robot wrote: > net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. > > NULL check before some freeing functions is not needed. > > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci > > CC: Roopa Prabhu > Signed-off-by: Fengguang Wu > FWIW, Acked-by: Roopa Prabhu