From: Sasha Levin <sasha.levin@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: xeb@mail.ru, ebiederm@xmission.com, davem@davemloft.net,
simon@farnz.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pptp: avoid releasing the sock too early
Date: Tue, 15 Sep 2015 13:39:10 -0400 [thread overview]
Message-ID: <55F857BE.6060201@oracle.com> (raw)
In-Reply-To: <1442249027.14284.2.camel@edumazet-glaptop2.roam.corp.google.com>
On 09/14/2015 12:43 PM, Eric Dumazet wrote:
> Hmm, is the synchronize_rcu() in del_chan() still needed, and why it was
> not enough ?
>
> I believe your patch might reduce the race window, but it is not clear
> it is the right fix.
You're right, I've missed the synchronize_rcu() originally. At this point
I'm certain that my patch is incorrect (so ignore it please), but I don't see
the cause of the bug either.
Let me think about it some more...
Thanks,
Sasha
prev parent reply other threads:[~2015-09-15 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 15:40 [PATCH] pptp: avoid releasing the sock too early Sasha Levin
2015-09-14 16:43 ` Eric Dumazet
2015-09-15 17:39 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F857BE.6060201@oracle.com \
--to=sasha.levin@oracle.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon@farnz.org.uk \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).