From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ondrej Zary <linux@rainbow-software.org>, Dan Williams <dcbw@redhat.com>
Cc: netdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] airo: Implement netif_carrier_on/off
Date: Wed, 16 Sep 2015 17:30:22 +0300 [thread overview]
Message-ID: <55F97CFE.3020806@cogentembedded.com> (raw)
In-Reply-To: <1442330289-2907-2-git-send-email-linux@rainbow-software.org>
Hello.
On 9/15/2015 6:18 PM, Ondrej Zary wrote:
> Add calls to netif_carrier_on and netif_carrier_off
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> ---
> drivers/net/wireless/airo.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
> index a8f2767..629245c 100644
> --- a/drivers/net/wireless/airo.c
> +++ b/drivers/net/wireless/airo.c
[...]
> @@ -3277,7 +3278,9 @@ static void airo_handle_link(struct airo_info *ai)
> eth_zero_addr(wrqu.ap_addr.sa_data);
> wrqu.ap_addr.sa_family = ARPHRD_ETHER;
> wireless_send_event(ai->dev, SIOCGIWAP, &wrqu, NULL);
> - }
> + netif_carrier_off(ai->dev);
> + } else
> + netif_carrier_off(ai->dev);
Need {} in all branches, according the the Documentation/CodingStyle.
> }
>
> static void airo_handle_rx(struct airo_info *ai)
[...]
MBR, Sergei
next prev parent reply other threads:[~2015-09-16 14:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 15:18 [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM Ondrej Zary
2015-09-15 15:18 ` [PATCH 2/2] airo: Implement netif_carrier_on/off Ondrej Zary
2015-09-16 14:30 ` Sergei Shtylyov [this message]
2015-09-18 16:54 ` [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM Dan Williams
2015-09-18 20:06 ` Ondrej Zary
2015-09-18 21:40 ` Dan Williams
2015-09-21 11:39 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2015-08-31 19:19 [PATCH 1/2] " Ondrej Zary
2015-08-31 19:19 ` [PATCH 2/2] airo: Implement netif_carrier_on/off Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F97CFE.3020806@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=dcbw@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).