Netdev List
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	David Ahern <dsa@cumulusnetworks.com>,
	netdev@vger.kernel.org
Cc: sergey.senozhatsky.work@gmail.com, richard.alpe@ericsson.com,
	festevam@gmail.com
Subject: Re: [PATCH net-next] net: Initialize table in fib result
Date: Wed, 16 Sep 2015 10:04:30 -0600	[thread overview]
Message-ID: <55F9930E.5060305@cumulusnetworks.com> (raw)
In-Reply-To: <55F99115.3020307@cumulusnetworks.com>

On 9/16/15 9:56 AM, Nikolay Aleksandrov wrote:
> Just to have it documented: I don't think we need the second NULLing,
> but it doesn't hurt.

I think we do. After the second one there is a goto to local_input which 
uses res.table. The second goto is reachable 'if 
!IN_DEV_FORWARD(in_dev)' in which case res.table is valid but should not 
be. In short if fi is reset, table should be.

  reply	other threads:[~2015-09-16 16:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 15:38 [PATCH net-next] net: Initialize table in fib result David Ahern
2015-09-16 15:56 ` Nikolay Aleksandrov
2015-09-16 16:04   ` David Ahern [this message]
2015-09-16 16:09 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F9930E.5060305@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=festevam@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=richard.alpe@ericsson.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox