From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set. Date: Sat, 18 Aug 2007 11:36:24 -0500 Message-ID: <55FCD650-548C-40C9-8B1E-16259EF93F1D@kernel.crashing.org> References: <20070817181718.GA15792@ld0162-tx32.am.freescale.net> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Content-Transfer-Encoding: 7bit Cc: jgarzik@pobox.com, netdev@vger.kernel.org, linuxppc-dev@ozlabs.org To: Scott Wood Return-path: Received: from gate.crashing.org ([63.228.1.57]:40013 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755914AbXHRQer (ORCPT ); Sat, 18 Aug 2007 12:34:47 -0400 In-Reply-To: <20070817181718.GA15792@ld0162-tx32.am.freescale.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Aug 17, 2007, at 1:17 PM, Scott Wood wrote: > The existing OF glue code was crufty and broken. Rather than fix > it, it > will be removed, and the ethernet driver now talks to the device tree > directly. > > The old, non-CONFIG_PPC_CPM_NEW_BINDING code can go away once CPM > platforms are dropped from arch/ppc (which will hopefully be soon), > and > existing arch/powerpc boards that I wasn't able to test on for this > patchset get converted (which should be even sooner). > > mii-bitbang.c now also uses the generic bitbang code. > > Signed-off-by: Scott Wood > --- > Sorry, the previous version of this patch had bb_ops in the wrong > place, and wouldn't build when not using the new binding. This patch seems to mix moving to using the device tree directly w/o some other modifications. Can it be broken into those two changes as they'd be easier to review. - k