From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE3E2FFDEA for ; Tue, 14 Oct 2025 14:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760453908; cv=none; b=pN1E+QtMmKDknyHIbP52zwp9qyl7ztMD+8DunFMg7nLqC6kB4wiYNaFeE8Wu+Z1iMWjfse8i/i4LP23ZhGbuSoQ09QUr3lfKyqbA9VPzCU8KqOW5u+DB5vtUrxiYYGxtvybBfkgygXE3AHS/NJPDXO5o+al2D2RItEC7DDUaGdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760453908; c=relaxed/simple; bh=R2Sf2U8v7Pq+Fg3Z0NqLmsByNIeFp1YqvdAKF4SarPQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BS1n5nJ/eJOEl6AY957hTMqN/VyKY/NtZoWCmH+DWwvB+ObwMf6M7ffH9K1vfhC3ku1ZmUcW/iGeLihOV5sJxXFG1idBTg4yPsoSO74qkCnFpdBtW0vxhxSSbs4mLXhLFHC4pHuE1TdK/7lo6WX12l1EdXJyx/a7Y/hSO5agTWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=p0kQet/l; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="p0kQet/l" Message-ID: <55adf770-a6b2-46d0-98bd-cbcc03e344b0@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1760453894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jvro9e9/KYoRyaECvLBiqtrB+AY8FxjZREzbiFZyRD8=; b=p0kQet/lLU+N4ylar5G4lDbEKyiMXbnIJ7BQQ9ZSf762+Cth2LXQuCyPSeHwNggxPojWsg mCkAirn0ydepA4z/aJC9y3ejtFVbnF0dlmCH15xAYnEUZhVY+SV2UjWXxzXgwiAAL5wD5b drxTDwxRVnSJUmF6+m8wE2L8Jx490kE= Date: Tue, 14 Oct 2025 15:58:11 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net] gve: Check valid ts bit on RX descriptor before hw timestamping To: Harshitha Ramamurthy , netdev@vger.kernel.org Cc: joshwash@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, willemb@google.com, pkaligineedi@google.com, jfraker@google.com, ziweixiao@google.com, thostet@google.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20251014004740.2775957-1-hramamurthy@google.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20251014004740.2775957-1-hramamurthy@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 14/10/2025 01:47, Harshitha Ramamurthy wrote: > From: Tim Hostetler > > The device returns a valid bit in the LSB of the low timestamp byte in > the completion descriptor that the driver should check before > setting the SKB's hardware timestamp. If the timestamp is not valid, do not > hardware timestamp the SKB. > > Cc: stable@vger.kernel.org > Fixes: b2c7aeb49056 ("gve: Implement ndo_hwtstamp_get/set for RX timestamping") > Reviewed-by: Joshua Washington > Signed-off-by: Tim Hostetler > Signed-off-by: Harshitha Ramamurthy Reviewed-by: Vadim Fedorenko