From mboxrd@z Thu Jan  1 00:00:00 1970
From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Subject: Re: [PATCH net-next RFC 5/8] net: deconstify net_offload
Date: Fri, 14 Sep 2018 21:30:36 -0600
Message-ID: <55c49b73544397757ad2cf22598519b1@codeaurora.org>
References: <20180914175941.213950-1-willemdebruijn.kernel@gmail.com>
 <20180914175941.213950-6-willemdebruijn.kernel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, pabeni@redhat.com,
        steffen.klassert@secunet.com, davem@davemloft.net,
        Willem de Bruijn <willemb@google.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:55744 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726295AbeIOIsA (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 15 Sep 2018 04:48:00 -0400
In-Reply-To: <20180914175941.213950-6-willemdebruijn.kernel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2018-09-14 11:59, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
> 
> With configurable gro, the flags field in net_offloads may be changed.
> 
> Remove the const keyword. This is a noop otherwise.
> 
> Signed-off-by: Willem de Bruijn <willemb@google.com>
> diff --git a/net/sctp/offload.c b/net/sctp/offload.c
> index 123e9f2dc226..ad504b83245d 100644
> --- a/net/sctp/offload.c
> +++ b/net/sctp/offload.c
> @@ -90,7 +90,7 @@ static struct sk_buff *sctp_gso_segment(struct 
> sk_buff
> *skb,
>  	return segs;
>  }
> 
> -static const struct net_offload sctp_offload = {
> +static struct net_offload sctp_offload = {
>  	.callbacks = {
>  		.gso_segment = sctp_gso_segment,
>  	},

Hi Willem

sctp6 also needs to be deconstified.

diff --git a/net/sctp/offload.c b/net/sctp/offload.c
index ad504b8..4be7794 100644
--- a/net/sctp/offload.c
+++ b/net/sctp/offload.c
@@ -96,7 +96,7 @@ static struct sk_buff *sctp_gso_segment(struct sk_buff 
*skb,
         },
  };

-static const struct net_offload sctp6_offload = {
+static struct net_offload sctp6_offload = {
         .callbacks = {
                 .gso_segment = sctp_gso_segment,
         },


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project