From: Paolo Abeni <pabeni@redhat.com>
To: Vikas Gupta <vikas.gupta@broadcom.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
andrew+netdev@lunn.ch, horms@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, leonro@nvidia.com, jgg@nvidia.com,
bhargava.marreddy@broadcom.com, rahul-rg.gupta@broadcom.com,
vsrama-krishna.nemani@broadcom.com,
rajashekar.hudumula@broadcom.com, ajit.khaparde@broadcom.com,
Siva Reddy Kallam <siva.kallam@broadcom.com>,
Dharmender Garg <dharmender.garg@broadcom.com>,
Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
Subject: Re: [PATCH net] bnge/bng_re: fix ring ID widths
Date: Fri, 3 Jul 2026 09:33:33 +0200 [thread overview]
Message-ID: <55e4bc6f-f393-4e76-9220-a818b28c585b@redhat.com> (raw)
In-Reply-To: <20260630101554.1221733-1-vikas.gupta@broadcom.com>
On 6/30/26 12:15 PM, Vikas Gupta wrote:
> diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h b/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h
> index 341c7f81ed09..bb0c79a1ee60 100644
> --- a/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h
> +++ b/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h
> @@ -184,7 +184,7 @@ struct bnge_ctx_mem_info {
> struct bnge_ring_struct {
> struct bnge_ring_mem_info ring_mem;
>
> - u16 fw_ring_id;
> + u32 fw_ring_id;
Sashiko gemini has a few concerns about the id size increases:
https://sashiko.dev/#/patchset/20260630101554.1221733-1-vikas.gupta%40broadcom.com
please have a look.
/P
next prev parent reply other threads:[~2026-07-03 7:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 10:15 [PATCH net] bnge/bng_re: fix ring ID widths Vikas Gupta
2026-07-03 7:33 ` Paolo Abeni [this message]
2026-07-03 8:59 ` Vikas Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55e4bc6f-f393-4e76-9220-a818b28c585b@redhat.com \
--to=pabeni@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhargava.marreddy@broadcom.com \
--cc=davem@davemloft.net \
--cc=dharmender.garg@broadcom.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rahul-rg.gupta@broadcom.com \
--cc=rajashekar.hudumula@broadcom.com \
--cc=siva.kallam@broadcom.com \
--cc=vikas.gupta@broadcom.com \
--cc=vsrama-krishna.nemani@broadcom.com \
--cc=yendapally.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox