From: Jeremy Harris <jgh@redhat.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] net sysfs: Print link speed as signed integer
Date: Tue, 29 Sep 2015 16:13:46 +0100 [thread overview]
Message-ID: <560AAAAA.1020605@redhat.com> (raw)
In-Reply-To: <1443445533-14474-1-git-send-email-alexander.stein@systec-electronic.com>
On 28/09/15 14:05, Alexander Stein wrote:
> Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link.
> Documentation/ABI/testing/sysfs-class-net does not state if this shall be
> signed or unsigned.
> Also remove the now unused variable fmt_udec.
[...]
> - ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd));
> + ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd));
If we print anything numeric, why is zero not appropriate
(which would still be unsigned)?
--
Cheers,
Jeremy
next prev parent reply other threads:[~2015-09-29 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 13:05 [PATCH v2 1/1] net sysfs: Print link speed as signed integer Alexander Stein
2015-09-29 15:13 ` Jeremy Harris [this message]
2015-09-29 21:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560AAAAA.1020605@redhat.com \
--to=jgh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).