From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH/RFC v2 net-next 3/4] ravb: Document binding for r8a7795 SoC Date: Wed, 30 Sep 2015 21:26:52 +0300 Message-ID: <560C296C.9080403@cogentembedded.com> References: <1441936878-18290-1-git-send-email-horms+renesas@verge.net.au> <1441936878-18290-4-git-send-email-horms+renesas@verge.net.au> <55F2E44D.6010505@cogentembedded.com> <20150914004207.GA6230@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Magnus Damm , Florian Fainelli , Geert Uytterhoeven , Kazuya Mizuguchi To: Simon Horman Return-path: Received: from mail-la0-f54.google.com ([209.85.215.54]:35740 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbbI3S05 (ORCPT ); Wed, 30 Sep 2015 14:26:57 -0400 Received: by laer8 with SMTP id r8so56665573lae.2 for ; Wed, 30 Sep 2015 11:26:55 -0700 (PDT) In-Reply-To: <20150914004207.GA6230@verge.net.au> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 09/14/2015 03:42 AM, Simon Horman wrote: Sorry for delayed reply, I thought I'd already replied to this. :-/ >>> From: Kazuya Mizuguchi >>> >>> This patch updates the ravb binding to support the r8a7795 SoC by: >>> - Adding a compat string for the new hardware >>> - Adding 25 named interrupts to binding for the new SoC; >>> older SoCs continue to use a single multiplexed interrupt >>> >>> The example is also updated to reflect the r8a7795 as this is the >>> more complex case. >>> >>> Based on work by Kazuya Mizuguchi and others. >>> >>> Signed-off-by: Simon Horman >>> >>> --- >>> >>> v2 >>> * First post; broken out of a driver update patch >>> * As discussed with Geert Uytterhoeven and Sergei Shtylyov >>> - Binding: Make all interrupts mandatory as named-interrupts of >>> the form ch%u >>> --- >>> .../devicetree/bindings/net/renesas,ravb.txt | 65 +++++++++++++++++++--- >>> 1 file changed, 58 insertions(+), 7 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> index 1fd8831437bf..6c360f993d33 100644 >>> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt >>> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt >> [...] >>> @@ -27,13 +33,46 @@ Optional properties: >>> Example: >>> >>> ethernet@e6800000 { >>> - compatible = "renesas,etheravb-r8a7790"; >>> - reg = <0 0xe6800000 0 0x800>, <0 0xee0e8000 0 0x4000>; >>> + compatible = "renesas,etheravb-r8a7795"; >>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>; >>> interrupt-parent = <&gic>; >>> - interrupts = <0 163 IRQ_TYPE_LEVEL_HIGH>; >>> - clocks = <&mstp8_clks R8A7790_CLK_ETHERAVB>; >>> - phy-mode = "rmii"; >>> + interrupts = , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + , >>> + ; >>> + interrupt-names = "ch0", "ch1", "ch2", "ch3", >>> + "ch4", "ch5", "ch6", "ch7", >>> + "ch8", "ch9", "ch10", "ch11", >>> + "ch12", "ch13", "ch14", "ch15", >>> + "ch16", "ch17", "ch18", "ch19", >>> + "ch20", "ch21", "ch22", "ch23", >>> + "ch24"; >> >> To me, these names don't look very helpful. You could as well omit them >> and use platform_get_irq() with the channel #. > These names reflect the hardware; which is the aim of DT. Indeed (I've looked into the manuals by now). They just look poorly chosen. :-) > As I believe you pointed out earlier it is preferred to use named > interrupts when there is more than one. Do I misunderstand the situation > there? Yes. > If you have a positive contribution to make regarding better names then > I am all ears. I liked your "tx", "rx" variant better... MBR, Sergei