From: Felix Fietkau <nbd@openwrt.org>
To: Neil Armstrong <narmstrong@baylibre.com>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations
Date: Fri, 2 Oct 2015 15:25:09 +0200 [thread overview]
Message-ID: <560E85B5.8090208@openwrt.org> (raw)
In-Reply-To: <560E60E4.8020706@baylibre.com>
On 2015-10-02 12:48, Neil Armstrong wrote:
> To simplify and prevent memory leakage when unbinding, use
> the devm_ memory allocation calls.
>
> Tested-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
I think you also need to get rid of the corresponding free calls in the
error path, otherwise it will probably crash at some point.
- Felix
next prev parent reply other threads:[~2015-10-02 13:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 10:48 [PATCH 1/3] net: dsa: Use devm_ prefixed allocations Neil Armstrong
2015-10-02 13:25 ` Felix Fietkau [this message]
2015-10-02 13:29 ` Sergei Shtylyov
2015-10-02 13:30 ` Neil Armstrong
2015-10-02 13:37 ` Sergei Shtylyov
2015-10-03 12:39 ` Felix Fietkau
2015-10-03 13:55 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560E85B5.8090208@openwrt.org \
--to=nbd@openwrt.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).