Re: [PATCH net-next v2] bridge: allow adding of fdb entries pointing to the bridge device

[Nikolay Aleksandrov <nikolay@cumulusnetworks.com>]

On 10/06/2015 06:06 PM, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> 
> This patch enables adding of fdb entries pointing to the bridge device.
> This can be used to propagate mac address of vlan interfaces
> configured on top of the vlan filtering bridge.
> 
> Before:
> $bridge fdb add 44:38:39:00:27:9f dev bridge
> RTNETLINK answers: Invalid argument
> 
> After:
> $bridge fdb add 44:38:39:00:27:9f dev bridge
> 
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> Reviewed-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
>  net/bridge/br_fdb.c | 110 ++++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 85 insertions(+), 25 deletions(-)
> 

Ugh my bad, Dave please don't apply this version, there're still a few rough
edges we need to take care of. Now that bridge's vlan_group can be used in these
functions the vlans should be checked for context-only, i.e. br_vlan_should_use()
and also when a port vlan is deleted its fdb entries are flushed, but that is not
done for the bridge since it wasn't possible to add them like this. So v3 coming
soon to your neighborhood! :-)

Thanks,
 Nik