From: Maurizio Lombardi <mlombard@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>, linux-scsi@vger.kernel.org
Cc: QLogic-Storage-Upstream@qlogic.com,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Joe Carnuccio <joe.carnuccio@qlogic.com>,
Chad Dupuis <chad.dupuis@qlogic.com>,
Yuval Mintz <Yuval.Mintz@qlogic.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable
Date: Wed, 7 Oct 2015 15:28:35 +0200 [thread overview]
Message-ID: <56151E03.4050908@redhat.com> (raw)
In-Reply-To: <5002023.QHmpbQ8s70@wuerfel>
Hi,
On 10/07/2015 03:11 PM, Arnd Bergmann wrote:
> - memset(&npiv_tbl, 0, sizeof(npiv_tbl));
> - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl))
> + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL);
> + if (!npiv_tbl)
> goto done;
>
If kzalloc() fails perhaps the function should return -ENOMEM, not zero.
Regards,
Maurizio Lombardi
next prev parent reply other threads:[~2015-10-07 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 13:11 [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable Arnd Bergmann
2015-10-07 13:28 ` Maurizio Lombardi [this message]
2015-10-07 18:49 ` Chad Dupuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56151E03.4050908@redhat.com \
--to=mlombard@redhat.com \
--cc=JBottomley@odin.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=Yuval.Mintz@qlogic.com \
--cc=arnd@arndb.de \
--cc=chad.dupuis@qlogic.com \
--cc=davem@davemloft.net \
--cc=joe.carnuccio@qlogic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).