netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: Cong Wang <cwang@twopensource.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] net: Add IPv6 support to VRF device
Date: Wed, 7 Oct 2015 12:52:42 -0600	[thread overview]
Message-ID: <561569FA.9090509@cumulusnetworks.com> (raw)
In-Reply-To: <5615687B.4070405@cumulusnetworks.com>

On 10/7/15 12:46 PM, David Ahern wrote:
> On 10/7/15 12:42 PM, Cong Wang wrote:
>> On Wed, Oct 7, 2015 at 9:50 AM, David Ahern <dsa@cumulusnetworks.com>
>> wrote:
>>> Add support for IPv6 to VRF device driver. Implemenation parallels what
>>> has been done for IPv4.
>> [...]
>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>> index b9ebd0d18a52..c878a0bc2137 100644
>>> --- a/drivers/net/Kconfig
>>> +++ b/drivers/net/Kconfig
>>> @@ -300,6 +300,7 @@ config NET_VRF
>>>          tristate "Virtual Routing and Forwarding (Lite)"
>>>          depends on IP_MULTIPLE_TABLES && IPV6_MULTIPLE_TABLES
>>>          depends on NET_L3_MASTER_DEV
>>> +       depends on IPV6
>>
>> So vrf will stop functioning without IPV6? This doesn't look correct...
>>
>
> The new functionality does. The inter-module/builtin dependencies are a
> nightmare. I either make VRF device require IPV6 like the IPVLAN driver
> does or I split the module into 2 -- 1 for IPv4 and 1 for IPv6.

Actually, I can't split it into because a netdevice can only have 1 
master yet can have both IPv4 and IPv6 addresses. I just noticed how 
bonding has it defined:

config BONDING
         tristate "Bonding driver support"
         depends on INET
         depends on IPV6 || IPV6=n


Let me try that style with VRF.

David

  reply	other threads:[~2015-10-07 18:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 16:50 [PATCH net-next 0/4] net: VRF support in IPv6 stack David Ahern
2015-10-07 16:50 ` [PATCH net-next 1/4] net: Add IPv6 support to l3mdev David Ahern
2015-10-07 16:50 ` [PATCH net-next 2/4] net: Export fib6_get_table and nd_tbl David Ahern
2015-10-07 16:50 ` [PATCH net-next 3/4] net: Add IPv6 support to VRF device David Ahern
2015-10-07 18:42   ` Cong Wang
2015-10-07 18:46     ` David Ahern
2015-10-07 18:52       ` David Ahern [this message]
2015-10-07 16:50 ` [PATCH net-next 4/4] net: Add VRF support to IPv6 stack David Ahern
  -- strict thread matches above, loose matches on Subject: below --
2015-10-07 22:02 [PATCH net-next 0/4 v2] net: VRF support in " David Ahern
2015-10-07 22:02 ` [PATCH net-next 3/4] net: Add IPv6 support to VRF device David Ahern
2015-10-12 18:47 [PATCH net-next 0/4 v3] net: VRF support in IPv6 stack David Ahern
2015-10-12 18:47 ` [PATCH net-next 3/4] net: Add IPv6 support to VRF device David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561569FA.9090509@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=cwang@twopensource.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).