From: Dan Williams <dcbw@redhat.com>
To: Andrew Lunn <andrew@lunn.ch>, Jian Yang <jianyang.kernel@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Mahesh Bandewar <maheshb@google.com>,
Jian Yang <jianyang@google.com>
Subject: Re: [PATCH net-next] net-loopback: allow lo dev initial state to be controlled
Date: Thu, 12 Nov 2020 13:54:28 -0600 [thread overview]
Message-ID: <5616ee6f15c2b9da73d23bcc23eca5befc824abe.camel@redhat.com> (raw)
In-Reply-To: <20201112160832.GB1456319@lunn.ch>
On Thu, 2020-11-12 at 17:08 +0100, Andrew Lunn wrote:
> On Wed, Nov 11, 2020 at 12:43:08PM -0800, Jian Yang wrote:
> > From: Mahesh Bandewar <maheshb@google.com>
> >
> > Traditionally loopback devices comes up with initial state as DOWN
> > for
> > any new network-namespace. This would mean that anyone needing this
> > device (which is mostly true except sandboxes where networking in
> > not
> > needed at all), would have to bring this UP by issuing something
> > like
> > 'ip link set lo up' which can be avoided if the initial state can
> > be set
> > as UP.
>
> How useful is lo if it is up, but has no IP address? I don't think
> this change adds the IP addresses does it? So you still need
> something
> inside your netns to add the IP addresses? Which seems to make this
> change pointless?
lo gets addresses automatically these days, no?
$ ip netns add blue
$ ip netns exec blue ip addr
1: lo: <LOOPBACK> mtu 65536 qdisc noop state DOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
$ ip netns exec blue ip link set lo up
$ ip netns exec blue ip addr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
Dan
next prev parent reply other threads:[~2020-11-12 19:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 20:43 [PATCH net-next] net-loopback: allow lo dev initial state to be controlled Jian Yang
2020-11-12 16:08 ` Andrew Lunn
2020-11-12 19:54 ` Dan Williams [this message]
2020-11-14 18:17 ` Jakub Kicinski
2020-11-16 20:02 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-16 20:17 ` Jakub Kicinski
2020-11-16 20:50 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-16 21:20 ` Jakub Kicinski
2020-11-16 21:42 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-16 20:34 ` Jakub Kicinski
2020-11-16 21:03 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-17 17:18 ` Ido Schimmel
2020-11-17 20:53 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-18 1:12 ` David Ahern
2020-11-18 16:58 ` Nicolas Dichtel
2020-11-18 17:39 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-18 18:04 ` David Ahern
2020-11-18 19:54 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-19 8:03 ` Nicolas Dichtel
2020-11-20 3:55 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-20 4:56 ` Jakub Kicinski
2020-12-01 20:24 ` Mahesh Bandewar (महेश बंडेवार)
2020-12-02 2:38 ` Jakub Kicinski
2020-12-02 20:53 ` Mahesh Bandewar (महेश बंडेवार)
2020-11-17 4:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5616ee6f15c2b9da73d23bcc23eca5befc824abe.camel@redhat.com \
--to=dcbw@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jianyang.kernel@gmail.com \
--cc=jianyang@google.com \
--cc=kuba@kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).