From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Andreas Schultz <aschultz@tpip.net>, netdev@vger.kernel.org
Cc: Pravin B Shelar <pshelar@nicira.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v4 1/2] fix return of iptunnel_xmit
Date: Fri, 9 Oct 2015 16:05:22 +0300 [thread overview]
Message-ID: <5617BB92.8000500@cogentembedded.com> (raw)
In-Reply-To: <1444382858-6725-2-git-send-email-aschultz@tpip.net>
Hello.
On 10/9/2015 12:27 PM, Andreas Schultz wrote:
> All users of iptunnel_xmit expect the return value to be the packet
> length on success (>0), negative for a tx error and zero for a tx
> dropped error. In cset 0e6fbc5b6c6218987c93b8c7ca60cf786062899d the
Didn't checkpatch.pl compalin about improper commit citing?
> negative return case was lost.
> This bug was introduced when the ip_tunnel_core code was refactored.
> Fixes: 0e6fbc5b6c6218987c93b8c7ca60cf786062899d
See Documentation/SubmittingPatches for the proper format of this tag.
> Signed-off-by: Andreas Schultz <aschultz@tpip.net>
> Acked-by: Jiri Benc <jbenc@redhat.com>
> Acked-by: Pravin B Shelar <pshelar@nicira.com>
MBR, Sergei
next prev parent reply other threads:[~2015-10-09 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 9:27 [PATCH net-next v4 0/2] fix tunnel statistics handling Andreas Schultz
2015-10-09 9:27 ` [PATCH net-next v4 1/2] fix return of iptunnel_xmit Andreas Schultz
2015-10-09 13:05 ` Sergei Shtylyov [this message]
2015-10-09 18:11 ` Debabrata Banerjee
2015-10-09 9:27 ` [PATCH net-next v4 2/2] tipc: remove invalid ip_rt_put Andreas Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5617BB92.8000500@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=aschultz@tpip.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).