Re: [PATCH net-next V15 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 10/11/2015 2:40 AM, Thomas F Herbert wrote:

> Signed-off-by: Thomas F Herbert <thomasfherbert@gmail.com>
> ---
>   include/linux/if_vlan.h | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
>
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 67ce5bd..88d1be4 100644
> --- a/include/linux/if_vlan.h
> +++ b/include/linux/if_vlan.h
> @@ -627,6 +627,23 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
>
>   	return features;
>   }
> +/**
> + * eth_type_vlan - check for valid vlan ether type.
> + * @ethertype: ether type to check
> + *
> + * Returns true if the ether type is a vlan ether type.
> + */
> +static inline bool eth_type_vlan(__be16 ethertype)
> +{
> +	switch (ethertype) {
> +	case (htons(ETH_P_8021Q)):
> +		return true;
> +	case (htons(ETH_P_8021AD)):
> +		return true;

    I'm not sure if I've already suggested that or not but why not merge these 
2 cases?

> +	default:
> +		return false;
> +	}
> +}

[...]

MBR, Sergei