From: Alexei Starovoitov <ast@plumgrid.com>
To: Kaixu Xia <xiakaixu@huawei.com>,
davem@davemloft.net, acme@kernel.org, mingo@redhat.com,
a.p.zijlstra@chello.nl, masami.hiramatsu.pt@hitachi.com,
jolsa@kernel.org, daniel@iogearbox.net
Cc: wangnan0@huawei.com, linux-kernel@vger.kernel.org,
pi3orama@163.com, hekuang@huawei.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers
Date: Mon, 12 Oct 2015 12:29:34 -0700 [thread overview]
Message-ID: <561C0A1E.2080500@plumgrid.com> (raw)
In-Reply-To: <1444640563-159175-3-git-send-email-xiakaixu@huawei.com>
On 10/12/15 2:02 AM, Kaixu Xia wrote:
> +extern const struct bpf_func_proto bpf_perf_event_sample_enable_proto;
> +extern const struct bpf_func_proto bpf_perf_event_sample_disable_proto;
externs are unnecessary. Just make them static.
Also I prefer single helper that takes a flag, so we can extend it
instead of adding func_id for every little operation.
To avoid conflicts if you touch kernel/bpf/* or bpf.h please always
base your patches of net-next.
> + atomic_set(&map->perf_sample_disable, 0);
global flag per map is no go.
events are independent and should be treated as such.
Please squash these two patches, since they're part of one logical
feature. Splitting them like this only makes review harder.
next prev parent reply other threads:[~2015-10-12 19:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 9:02 [RFC PATCH 0/2] bpf: enable/disable events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Kaixu Xia
2015-10-12 9:02 ` [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples Kaixu Xia
2015-10-12 12:02 ` Peter Zijlstra
2015-10-12 12:05 ` Wangnan (F)
2015-10-12 12:12 ` Peter Zijlstra
2015-10-12 14:14 ` kbuild test robot
2015-10-12 19:20 ` Alexei Starovoitov
2015-10-13 2:30 ` xiakaixu
2015-10-13 3:10 ` Alexei Starovoitov
2015-10-13 12:00 ` Sergei Shtylyov
2015-10-12 9:02 ` [RFC PATCH 2/2] bpf: Implement bpf_perf_event_sample_enable/disable() helpers Kaixu Xia
2015-10-12 19:29 ` Alexei Starovoitov [this message]
2015-10-13 3:27 ` Wangnan (F)
2015-10-13 3:39 ` Alexei Starovoitov
2015-10-13 3:51 ` Wangnan (F)
2015-10-13 4:16 ` Alexei Starovoitov
2015-10-13 4:34 ` Wangnan (F)
2015-10-13 5:15 ` Alexei Starovoitov
2015-10-13 6:57 ` Wangnan (F)
2015-10-13 10:54 ` He Kuang
2015-10-13 11:07 ` Wangnan (F)
2015-10-14 5:14 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561C0A1E.2080500@plumgrid.com \
--to=ast@plumgrid.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).