From: John Fastabend <john.fastabend@gmail.com>
To: Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>
Cc: Netdev <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Ido Schimmel <idosch@mellanox.com>, Elad Raz <eladr@mellanox.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
David Laight <David.Laight@aculab.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects
Date: Mon, 12 Oct 2015 21:44:23 -0700 [thread overview]
Message-ID: <561C8C27.20604@gmail.com> (raw)
In-Reply-To: <CAE4R7bBevBoQ=U7P98F2NEh97ocLgvZuc4cS0fZ9BYFapVeR3A@mail.gmail.com>
On 15-10-12 08:01 PM, Scott Feldman wrote:
> On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> When object is used in deferred work, we cannot use pointers in
>> switchdev object structures because the memory they point at may be already
>> used by someone else. So rather do local copy of the value.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
> Acked-by: Scott Feldman <sfeldma@gmail.com>
>
also fwiw
Reviewed-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2015-10-13 4:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 17:54 [patch net-next v4 0/7] switchdev: change locking Jiri Pirko
2015-10-12 17:54 ` [patch net-next v4 1/7] switchdev: introduce switchdev workqueue Jiri Pirko
2015-10-13 3:01 ` Scott Feldman
2015-10-12 18:03 ` [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred Jiri Pirko
2015-10-12 18:03 ` [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects Jiri Pirko
2015-10-13 3:01 ` Scott Feldman
2015-10-13 4:44 ` John Fastabend [this message]
2015-10-12 18:03 ` [patch net-next v4 4/7] switchdev: introduce possibility to defer obj_add/del Jiri Pirko
2015-10-13 3:08 ` Scott Feldman
2015-10-12 18:03 ` [patch net-next v4 5/7] bridge: defer switchdev fdb del call in fdb_del_external_learn Jiri Pirko
2015-10-13 3:28 ` Scott Feldman
2015-10-13 3:31 ` John Fastabend
2015-10-13 4:19 ` Scott Feldman
2015-10-13 5:16 ` John Fastabend
2015-10-13 6:05 ` Jiri Pirko
2015-10-13 6:46 ` Scott Feldman
2015-10-12 18:03 ` [patch net-next v4 6/7] rocker: remove nowait from switchdev callbacks Jiri Pirko
2015-10-13 4:02 ` Scott Feldman
2015-10-13 6:25 ` Jiri Pirko
2015-10-13 6:55 ` Scott Feldman
2015-10-12 18:03 ` [patch net-next v4 7/7] switchdev: assert rtnl mutex when going over lower netdevs Jiri Pirko
2015-10-13 2:52 ` [patch net-next v4 2/7] switchdev: allow caller to explicitly request attr_set as deferred Scott Feldman
2015-10-13 4:40 ` John Fastabend
2015-10-13 5:45 ` Jiri Pirko
2015-10-13 5:48 ` John Fastabend
2015-10-13 5:44 ` Jiri Pirko
2015-10-13 6:03 ` John Fastabend
2015-10-13 6:21 ` Jiri Pirko
2015-10-13 6:53 ` Scott Feldman
2015-10-13 7:30 ` Jiri Pirko
2015-10-13 14:07 ` Scott Feldman
2015-10-13 14:39 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561C8C27.20604@gmail.com \
--to=john.fastabend@gmail.com \
--cc=David.Laight@aculab.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).