From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [patch net-next v4 3/7] switchdev: remove pointers from switchdev objects Date: Mon, 12 Oct 2015 21:44:23 -0700 Message-ID: <561C8C27.20604@gmail.com> References: <1444672467-20621-1-git-send-email-jiri@resnulli.us> <1444672986-20709-1-git-send-email-jiri@resnulli.us> <1444672986-20709-2-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Netdev , "David S. Miller" , Ido Schimmel , Elad Raz , Florian Fainelli , Guenter Roeck , Vivien Didelot , "andrew@lunn.ch" , David Laight , "stephen@networkplumber.org" To: Scott Feldman , Jiri Pirko Return-path: Received: from mail-pa0-f51.google.com ([209.85.220.51]:35720 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbbJMEok (ORCPT ); Tue, 13 Oct 2015 00:44:40 -0400 Received: by pabve7 with SMTP id ve7so8929571pab.2 for ; Mon, 12 Oct 2015 21:44:39 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 15-10-12 08:01 PM, Scott Feldman wrote: > On Mon, Oct 12, 2015 at 11:03 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> When object is used in deferred work, we cannot use pointers in >> switchdev object structures because the memory they point at may be already >> used by someone else. So rather do local copy of the value. >> >> Signed-off-by: Jiri Pirko > > Acked-by: Scott Feldman > also fwiw Reviewed-by: John Fastabend