From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code
Date: Tue, 13 Oct 2015 10:35:37 -0700 [thread overview]
Message-ID: <561D40E9.8030602@gmail.com> (raw)
In-Reply-To: <1444754783-26975-4-git-send-email-vivien.didelot@savoirfairelinux.com>
On 13/10/15 09:46, Vivien Didelot wrote:
> There is no need to write the MAC address before every Get Next
> operation, since ATU MAC registers are not cleared between calls.
>
> Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext
> so future code could call ATU Get Next multiple times and save a few
> register access.
Missing SoB tag here.
--
Florian
next prev parent reply other threads:[~2015-10-13 17:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 16:46 [PATCH net-next v2 0/6] net: dsa: implement port_fdb_dump in drivers Vivien Didelot
2015-10-13 16:46 ` [PATCH net-next v2 1/6] net: dsa: add port_fdb_dump function Vivien Didelot
2015-10-14 13:12 ` David Miller
2015-10-14 18:49 ` Florian Fainelli
2015-10-13 16:46 ` [PATCH net-next v2 2/6] net: dsa: mv88e6xxx: write VID outside of VTU Get Next code Vivien Didelot
2015-10-13 16:46 ` [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU " Vivien Didelot
2015-10-13 17:35 ` Florian Fainelli [this message]
2015-10-13 18:11 ` Vivien Didelot
2015-10-13 18:43 ` Florian Fainelli
2015-10-13 18:48 ` Vivien Didelot
2015-10-13 16:46 ` [PATCH net-next v2 4/6] net: dsa: mv88e6xxx: implement port_fdb_dump Vivien Didelot
2015-10-14 17:38 ` Scott Feldman
2015-10-13 16:46 ` [PATCH net-next v2 5/6] net: dsa: mv88e6xxx: remove port_fdb_getnext Vivien Didelot
2015-10-13 16:46 ` [PATCH net-next v2 6/6] net: dsa: " Vivien Didelot
2015-10-14 18:50 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D40E9.8030602@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).