* [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad
2015-10-15 14:01 [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad Thomas F Herbert
@ 2015-10-15 14:01 ` Thomas F Herbert
2015-10-15 14:05 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Thomas F Herbert @ 2015-10-15 14:01 UTC (permalink / raw)
To: netdev, pshelar; +Cc: therbert, dev, Thomas F Herbert
---
include/linux/if_vlan.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..ac23521 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,22 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
return features;
}
+/**
+ * eth_type_vlan - check for valid vlan ether type.
+ * @ethertype: ether type to check
+ *
+ * Returns true if the ether type is a vlan ether type.
+ */
+static inline bool eth_type_vlan(__be16 ethertype)
+{
+ switch (ethertype) {
+ case (htons(ETH_P_8021Q)):
+ case (htons(ETH_P_8021AD)):
+ return true;
+ default:
+ return false;
+ }
+}
/**
* compare_vlan_header - Compare two vlan headers
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad
2015-10-15 14:01 ` [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad Thomas F Herbert
@ 2015-10-15 14:05 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2015-10-15 14:05 UTC (permalink / raw)
To: Thomas F Herbert, netdev, pshelar; +Cc: therbert, dev
On 10/15/2015 5:01 PM, Thomas F Herbert wrote:
Hm, I'm seeing no sign-off on this patch.
> ---
> include/linux/if_vlan.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 67ce5bd..ac23521 100644
> --- a/include/linux/if_vlan.h
> +++ b/include/linux/if_vlan.h
> @@ -627,6 +627,22 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
>
> return features;
> }
> +/**
> + * eth_type_vlan - check for valid vlan ether type.
> + * @ethertype: ether type to check
> + *
> + * Returns true if the ether type is a vlan ether type.
> + */
> +static inline bool eth_type_vlan(__be16 ethertype)
> +{
> + switch (ethertype) {
> + case (htons(ETH_P_8021Q)):
> + case (htons(ETH_P_8021AD)):
Hm, I thought you had a request to delete the outer parens already...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad
@ 2015-10-15 14:36 Thomas F Herbert
2015-10-15 17:19 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Thomas F Herbert @ 2015-10-15 14:36 UTC (permalink / raw)
To: netdev, pshelar; +Cc: sergei.shtylyov, Thomas F Herbert
Signed-off-by: Thomas F Herbert <thomasfherbert@gmail.com>
---
include/linux/if_vlan.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..ac23521 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,22 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
return features;
}
+/**
+ * eth_type_vlan - check for valid vlan ether type.
+ * @ethertype: ether type to check
+ *
+ * Returns true if the ether type is a vlan ether type.
+ */
+static inline bool eth_type_vlan(__be16 ethertype)
+{
+ switch (ethertype) {
+ case (htons(ETH_P_8021Q)):
+ case (htons(ETH_P_8021AD)):
+ return true;
+ default:
+ return false;
+ }
+}
/**
* compare_vlan_header - Compare two vlan headers
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad
2015-10-15 14:36 [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad Thomas F Herbert
@ 2015-10-15 17:19 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2015-10-15 17:19 UTC (permalink / raw)
To: Thomas F Herbert, netdev, pshelar
On 10/15/2015 05:36 PM, Thomas F Herbert wrote:
> Signed-off-by: Thomas F Herbert <thomasfherbert@gmail.com>
> ---
> include/linux/if_vlan.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
> index 67ce5bd..ac23521 100644
> --- a/include/linux/if_vlan.h
> +++ b/include/linux/if_vlan.h
> @@ -627,6 +627,22 @@ static inline netdev_features_t vlan_features_check(const struct sk_buff *skb,
>
> return features;
> }
> +/**
> + * eth_type_vlan - check for valid vlan ether type.
> + * @ethertype: ether type to check
> + *
> + * Returns true if the ether type is a vlan ether type.
> + */
> +static inline bool eth_type_vlan(__be16 ethertype)
> +{
> + switch (ethertype) {
> + case (htons(ETH_P_8021Q)):
> + case (htons(ETH_P_8021AD)):
Nothing changed here. :-(
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-15 17:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 14:36 [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad Thomas F Herbert
2015-10-15 17:19 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2015-10-15 14:01 [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad Thomas F Herbert
2015-10-15 14:01 ` [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad Thomas F Herbert
2015-10-15 14:05 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).