From mboxrd@z Thu Jan 1 00:00:00 1970 From: isdn@linux-pingi.de Subject: Re: [PATCH 2/2] isdn: correctly check failed allocation Date: Thu, 15 Oct 2015 20:42:04 +0200 Message-ID: <561FF37C.7070107@linux-pingi.de> References: <1444926568-29572-1-git-send-email-wuninsu@gmail.com> <1444926568-29572-2-git-send-email-wuninsu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu To: Insu Yun , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1444926568-29572-2-git-send-email-wuninsu@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Insu, thanks for bringing up this issue again. I thought I did fix this a year ago, but seems it did not managed to sent it upstream. The patch do not fix this completly, since it will drop the original skb from the L2 I frame queue, so the transmission would lost an I-FRAME, which is not allowed by the protocol. The format of the new lines is wrong, you need to use TAB. Best regards Karsten Am 15.10.2015 um 18:29 schrieb Insu Yun: > Since skb_clone is memory allocation, it could be failed when lack of resource. > Therefore, return value of skb_clone needs to be checked and handle error. > > Signed-off-by: Insu Yun > --- > drivers/isdn/mISDN/layer2.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c > index 949cabb..888c610 100644 > --- a/drivers/isdn/mISDN/layer2.c > +++ b/drivers/isdn/mISDN/layer2.c > @@ -1509,6 +1509,12 @@ l2_pull_iqueue(struct FsmInst *fi, int event, void *arg) > } > > nskb = skb_clone(skb, GFP_ATOMIC); > + if (!nskb) { > + printk(KERN_WARNING "%s: no skb mem in %s\n", > + mISDNDevName4ch(&l2->ch), __func__); > + return; > + } > + > p1 = skb_headroom(nskb); > if (p1 >= i) > memcpy(skb_push(nskb, i), header, i); >