* [PATCH] net: wireless: rt2x00: statics code style
@ 2015-10-17 20:25 Paul McQuade
2015-10-18 13:16 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Paul McQuade @ 2015-10-17 20:25 UTC (permalink / raw)
To: paulmcquad
Cc: sgruszka, helmut.schaa, kvalo, linux-wireless, netdev,
linux-kernel
Do not initialise statics to 0 or NULL
Also use tabs where possible
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/net/wireless/rt2x00/rt61pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
index c0e730e..53bd23d 100644
--- a/drivers/net/wireless/rt2x00/rt61pci.c
+++ b/drivers/net/wireless/rt2x00/rt61pci.c
@@ -39,7 +39,7 @@
/*
* Allow hardware encryption to be disabled.
*/
-static bool modparam_nohwcrypt = false;
+static bool modparam_nohwcrypt;
module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
@@ -1388,7 +1388,7 @@ static bool rt61pci_get_entry_state(struct queue_entry *entry)
rt2x00_desc_read(entry_priv->desc, 0, &word);
return (rt2x00_get_field32(word, TXD_W0_OWNER_NIC) ||
- rt2x00_get_field32(word, TXD_W0_VALID));
+ rt2x00_get_field32(word, TXD_W0_VALID));
}
}
--
2.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: wireless: rt2x00: statics code style
2015-10-17 20:25 [PATCH] net: wireless: rt2x00: statics code style Paul McQuade
@ 2015-10-18 13:16 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2015-10-18 13:16 UTC (permalink / raw)
To: Paul McQuade
Cc: sgruszka, helmut.schaa, kvalo, linux-wireless, netdev,
linux-kernel
Hello.
On 10/17/2015 11:25 PM, Paul McQuade wrote:
> Do not initialise statics to 0 or NULL
> Also use tabs where possible
>
> Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt61pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
> index c0e730e..53bd23d 100644
> --- a/drivers/net/wireless/rt2x00/rt61pci.c
> +++ b/drivers/net/wireless/rt2x00/rt61pci.c
> @@ -39,7 +39,7 @@
> /*
> * Allow hardware encryption to be disabled.
> */
> -static bool modparam_nohwcrypt = false;
> +static bool modparam_nohwcrypt;
> module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
> MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
>
> @@ -1388,7 +1388,7 @@ static bool rt61pci_get_entry_state(struct queue_entry *entry)
> rt2x00_desc_read(entry_priv->desc, 0, &word);
>
> return (rt2x00_get_field32(word, TXD_W0_OWNER_NIC) ||
> - rt2x00_get_field32(word, TXD_W0_VALID));
> + rt2x00_get_field32(word, TXD_W0_VALID));
This line should indented more, like it was before. And the outer parens
aren't needed.
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-18 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-17 20:25 [PATCH] net: wireless: rt2x00: statics code style Paul McQuade
2015-10-18 13:16 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).