From: xiakaixu <xiakaixu@huawei.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: <davem@davemloft.net>, <acme@kernel.org>, <mingo@redhat.com>,
<a.p.zijlstra@chello.nl>, <masami.hiramatsu.pt@hitachi.com>,
<jolsa@kernel.org>, <daniel@iogearbox.net>, <wangnan0@huawei.com>,
<linux-kernel@vger.kernel.org>, <pi3orama@163.com>,
<hekuang@huawei.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH V4 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling
Date: Tue, 20 Oct 2015 10:35:25 +0800 [thread overview]
Message-ID: <5625A86D.6050102@huawei.com> (raw)
In-Reply-To: <5625A36D.8070200@plumgrid.com>
于 2015/10/20 10:14, Alexei Starovoitov 写道:
> On 10/19/15 3:37 AM, Kaixu Xia wrote:
>> +/* flags for PERF_EVENT_ARRAY maps*/
>> +enum {
>> + BPF_EVENT_CTL_BIT_CUR = 0,
>> + BPF_EVENT_CTL_BIT_ALL = 1,
>> + __NR_BPF_EVENT_CTL_BITS,
>> +};
>> +
>> +#define BPF_CTL_BIT_FLAG_MASK \
>> + ((1ULL << __NR_BPF_EVENT_CTL_BITS) - 1)
>> +#define BPF_CTL_BIT_DUMP_CUR \
>> + (1ULL << BPF_EVENT_CTL_BIT_CUR)
>> +#define BPF_CTL_BIT_DUMP_ALL \
>> + (1ULL << BPF_EVENT_CTL_BIT_ALL)
>> +
>
> the above shouldn't be part of uapi header. It can stay in bpf_trace.c
> Just document these bits next to helper similar to skb_store_bytes()
>
> The rest looks ok.
> It still needs an ack from Peter for perf_event bits
Thanks for your comments!
This part will be moved to bpf_trace.c in next version.
>
>
> .
>
prev parent reply other threads:[~2015-10-20 2:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 10:37 [PATCH V4 0/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling Kaixu Xia
2015-10-19 10:37 ` [PATCH V4 1/1] " Kaixu Xia
2015-10-20 2:14 ` Alexei Starovoitov
2015-10-20 2:35 ` xiakaixu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5625A86D.6050102@huawei.com \
--to=xiakaixu@huawei.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pi3orama@163.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).