From: Florian Fainelli <f.fainelli@gmail.com>
To: "Andrew F. Davis" <afd@ti.com>, "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY
Date: Tue, 20 Oct 2015 14:53:58 -0700 [thread overview]
Message-ID: <5626B7F6.9010200@gmail.com> (raw)
In-Reply-To: <5626B757.7080800@ti.com>
On 20/10/15 14:51, Andrew F. Davis wrote:
> On 10/20/2015 04:37 PM, Florian Fainelli wrote:
>> On 20/10/15 14:28, Andrew F. Davis wrote:
>>> Add support for the TI DP83848 Ethernet PHY device.
>>>
>>> The DP83848 is a highly reliable, feature rich, IEEE 802.3 compliant
>>> single port 10/100 Mb/s Ethernet Physical Layer Transceiver supporting
>>> the MII and RMII interfaces.
>>>
>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>
>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>
>> Just one comment below:
>>
>> [snip]
>>
>>> diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile
>>> index 87f079c..b748224 100644
>>> --- a/drivers/net/phy/Makefile
>>> +++ b/drivers/net/phy/Makefile
>>> @@ -24,6 +24,7 @@ obj-$(CONFIG_MDIO_BITBANG) += mdio-bitbang.o
>>> obj-$(CONFIG_MDIO_GPIO) += mdio-gpio.o
>>> obj-$(CONFIG_NATIONAL_PHY) += national.o
>>> obj-$(CONFIG_DP83640_PHY) += dp83640.o
>>> +obj-$(CONFIG_DP83848_PHY) += dp83848.o
>>> obj-$(CONFIG_DP83867_PHY) += dp83867.o
>>
>> This is a pretty small PHY driver, would it make sense to look into
>> consolidating these into e.g: dp838xx.c for instance? dp83640 is big
>> enough to be its own driver it seems.
>>
>
> I was looking into that, but from the looks of it these drivers are small
> because only the functions that differentiate the PHYs need be defined.
> So there is very little common code between them.
>
> I'm going to be brining up a couple more PHYs soon, so I'll keep this in
> mind
> and try to find any redundancy that can be merged when working on these.
Sounds good, thanks for giving some context on this.
--
Florian
next prev parent reply other threads:[~2015-10-20 21:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 21:28 [PATCH] net: phy: dp83848: Add TI DP83848 Ethernet PHY Andrew F. Davis
2015-10-20 21:37 ` Florian Fainelli
2015-10-20 21:51 ` Andrew F. Davis
2015-10-20 21:53 ` Florian Fainelli [this message]
2015-10-21 0:06 ` Dan Murphy
2015-10-22 13:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5626B7F6.9010200@gmail.com \
--to=f.fainelli@gmail.com \
--cc=afd@ti.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).