From: Jiri Slaby <jslaby@suse.cz>
To: Punit Vara <punitvara@gmail.com>, kvalo@qca.qualcomm.com
Cc: stas.yakovlev@gmail.com, chaoming_li@realsil.com.cn,
Larry.Finger@lwfinger.net, chunkeey@googlemail.com,
sgruszka@redhat.com, brudley@broadcom.com, arend@broadcom.com,
linville@tuxdriver.com, mickflemm@gmail.com,
mcgrof@do-not-panic.com, k.eugene.e@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
brcm80211-dev-list@broadcom.com, wcn36xx@lists.infradead.org,
johannes.berg@intel.com, meuleman@broadcom.com
Subject: Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg
Date: Wed, 21 Oct 2015 17:00:31 +0200 [thread overview]
Message-ID: <5627A88F.3030608@suse.cz> (raw)
In-Reply-To: <1445439337-19055-9-git-send-email-punitvara@gmail.com>
On 10/21/2015, 04:55 PM, Punit Vara wrote:
> @@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void)
> static int at76_remap(struct usb_device *udev)
> {
> int ret;
> - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
> + return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
> USB_TYPE_VENDOR | USB_DIR_OUT |
> USB_RECIP_INTERFACE, 0, 0, NULL, 0,
> USB_CTRL_GET_TIMEOUT);
> - if (ret < 0)
> - return ret;
> - return 0;
ret is now unused, right?
--
js
suse labs
next prev parent reply other threads:[~2015-10-21 15:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 14:55 [PATCH 00/15] Fix warnings reported by coccicheck Punit Vara
2015-10-21 14:55 ` [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks Punit Vara
2015-10-21 14:58 ` Jiri Slaby
2015-10-21 21:43 ` Sergei Shtylyov
2015-10-22 18:22 ` punit vara
2015-10-21 14:55 ` [PATCH 02/15] net: wireless: ath: Remove unnecessary semicolon Punit Vara
2015-10-21 14:55 ` [PATCH 03/15] " Punit Vara
2015-10-21 14:55 ` [PATCH 04/15] net: wireless: ipw2x00: use | instead of + for summing bitmasks Punit Vara
2015-10-21 14:55 ` [PATCH 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Punit Vara
2015-10-21 15:40 ` kbuild test robot
2015-10-21 14:55 ` [PATCH 06/15] net: wireless: rtwifi: Remove duplicated arguments to | Punit Vara
2015-10-21 14:55 ` [PATCH 07/15] net: wireless: brcm80211: " Punit Vara
2015-10-21 14:55 ` [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg Punit Vara
2015-10-21 15:00 ` Jiri Slaby [this message]
2015-10-21 18:05 ` punit vara
2015-10-21 14:55 ` [PATCH 09/15] net: wireless: simplify return flow for zd1201_setconfig16 Punit Vara
2015-10-21 14:55 ` [PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Punit Vara
2015-10-21 14:55 ` [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret Punit Vara
2015-10-21 21:45 ` Sergei Shtylyov
2015-10-21 14:55 ` [PATCH 12/15] net: wireless: brcm80211: Remove unneeded variable which return 0 Punit Vara
2015-10-21 14:55 ` [PATCH 13/15] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Punit Vara
2015-10-21 14:55 ` [PATCH 14/15] net: wireless: ath: Remove unneeded variable ret " Punit Vara
2015-10-21 14:55 ` [PATCH 15/15] " Punit Vara
2015-10-21 21:46 ` Sergei Shtylyov
2015-10-22 18:23 ` punit vara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5627A88F.3030608@suse.cz \
--to=jslaby@suse.cz \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=brcm80211-dev-list@broadcom.com \
--cc=brudley@broadcom.com \
--cc=chaoming_li@realsil.com.cn \
--cc=chunkeey@googlemail.com \
--cc=johannes.berg@intel.com \
--cc=k.eugene.e@gmail.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@do-not-panic.com \
--cc=meuleman@broadcom.com \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=punitvara@gmail.com \
--cc=sgruszka@redhat.com \
--cc=stas.yakovlev@gmail.com \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).