From: Alexei Starovoitov <ast@plumgrid.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@kernel.org>, Wang Nan <wangnan0@huawei.com>,
He Kuang <hekuang@huawei.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper
Date: Wed, 21 Oct 2015 10:26:21 -0700 [thread overview]
Message-ID: <5627CABD.7030609@plumgrid.com> (raw)
In-Reply-To: <20151021120636.GB3604@twins.programming.kicks-ass.net>
On 10/21/15 5:06 AM, Peter Zijlstra wrote:
>> PERF_COUNT_SW_DUMMY = 9,
>> >+ PERF_COUNT_SW_BPF_OUTPUT = 10,
>> >
>> > PERF_COUNT_SW_MAX, /* non-ABI */
>> > };
> Do you really need the new type? Can't you use DUMMY for this?
It works fine with dummy, but user space code looked odd when
it perf_event_open-s dummy events and starts reading them.
So I thought either to add alias:
PERF_COUNT_SW_BPF_OUTPUT = PERF_COUNT_SW_DUMMY
or
add new number like I did above.
New number is cheap and I saw that dummy used for probing,
so went with new number to disambiguate.
next prev parent reply other threads:[~2015-10-21 17:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 3:02 [PATCH net-next 0/3] bpf_perf_event_output helper Alexei Starovoitov
2015-10-21 3:02 ` [PATCH net-next 1/3] perf: pad raw data samples automatically Alexei Starovoitov
2015-10-21 3:02 ` [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper Alexei Starovoitov
2015-10-21 10:01 ` He Kuang
2015-10-21 11:05 ` Wangnan (F)
2015-10-21 20:04 ` Alexei Starovoitov
2015-10-21 12:06 ` Peter Zijlstra
2015-10-21 17:26 ` Alexei Starovoitov [this message]
2015-10-21 19:33 ` Peter Zijlstra
2015-10-22 13:59 ` Peter Zijlstra
2015-10-22 15:38 ` Alexei Starovoitov
2015-10-23 14:39 ` Peter Zijlstra
2015-10-23 15:02 ` Alexei Starovoitov
2015-10-23 16:42 ` Peter Zijlstra
2015-10-23 17:25 ` Alexei Starovoitov
2015-10-26 1:46 ` Wangnan (F)
2015-10-26 10:27 ` Alexei Starovoitov
2015-10-21 3:02 ` [PATCH net-next 3/3] samples: bpf: add bpf_perf_event_output example Alexei Starovoitov
2015-10-22 13:42 ` [PATCH net-next 0/3] bpf_perf_event_output helper David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5627CABD.7030609@plumgrid.com \
--to=ast@plumgrid.com \
--cc=acme@infradead.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hekuang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).