From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Punit Vara <punitvara@gmail.com>, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, jslaby@suse.cz, lkp@intel.com
Subject: Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate
Date: Thu, 22 Oct 2015 01:00:02 +0300 [thread overview]
Message-ID: <56280AE2.6010502@cogentembedded.com> (raw)
In-Reply-To: <1445454428-12331-1-git-send-email-punitvara@gmail.com>
On 10/21/2015 10:07 PM, Punit Vara wrote:
> Remove int ret suggested by kbuild test robot
>
> This patch is to the wlcore/acx.c file that fixes up warning
> reported by coccicheck:
>
> WARNING: end returns can be simplified if negative or 0 value
>
> Prefer direct return value instead of writing 2-3 more sentence.
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/net/wireless/ti/wlcore/acx.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c
> index f28fa3b..6b566d9 100644
> --- a/drivers/net/wireless/ti/wlcore/acx.c
> +++ b/drivers/net/wireless/ti/wlcore/acx.c
> @@ -158,16 +158,11 @@ out:
> int wl1271_acx_mem_map(struct wl1271 *wl, struct acx_header *mem_map,
> size_t len)
> {
> - int ret;
>
You now need to kill this empty line as well.
[...]
MBR, Sergei+
next prev parent reply other threads:[~2015-10-21 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 19:07 [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Punit Vara
2015-10-21 19:07 ` [PATCH v2 08/15] net: wireless: simplify return flow for usb_control_msg Punit Vara
2015-10-21 22:00 ` Sergei Shtylyov [this message]
2015-10-22 6:54 ` [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56280AE2.6010502@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=jslaby@suse.cz \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=punitvara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).