* [PATCH 0/3] Refactor nested mdiobus read/write functions
@ 2015-10-22 8:37 Neil Armstrong
2015-10-22 13:18 ` Andrew Lunn
2015-10-23 13:00 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Neil Armstrong @ 2015-10-22 8:37 UTC (permalink / raw)
To: David S. Miller, Florian Fainelli, Guenter Roeck, vivien.didelot,
Andrew Lunn, Fabian Frederick, Pavel Nakonechny, Joe Perches,
netdev, linux-kernel, nbd, sergei.shtylyov
In order to avoid locked signal false positive for nested mdiobus
read/write calls, nested code was introduced in mv88e6xxx and
mdio-mux.
But mv88e6060 also needs such nested mdiobus read/write calls.
For sake of refactoring, introduce nested variants of mdiobus read/write
and make them used by mv88e6xxx and mv88e6060.
In a next patch, mdio-mux should also use these variant calls.
Neil Armstrong (3):
net: phy: Add nested variants of mdiobus read/write
net: dsa: Make mv88e6xxx use nested mdiobus read/write
net: dsa: Make mv88e6060 use nested mdiobus read/write
drivers/net/dsa/mv88e6060.c | 4 ++--
drivers/net/dsa/mv88e6xxx.c | 46 ++++++++-----------------------------
drivers/net/phy/mdio_bus.c | 55 +++++++++++++++++++++++++++++++++++++++++++++
include/linux/phy.h | 2 ++
4 files changed, 68 insertions(+), 39 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] Refactor nested mdiobus read/write functions
2015-10-22 8:37 [PATCH 0/3] Refactor nested mdiobus read/write functions Neil Armstrong
@ 2015-10-22 13:18 ` Andrew Lunn
2015-10-23 13:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2015-10-22 13:18 UTC (permalink / raw)
To: Neil Armstrong
Cc: David S. Miller, Florian Fainelli, Guenter Roeck, vivien.didelot,
Fabian Frederick, Pavel Nakonechny, Joe Perches, netdev,
linux-kernel, nbd, sergei.shtylyov
On Thu, Oct 22, 2015 at 10:37:45AM +0200, Neil Armstrong wrote:
> In order to avoid locked signal false positive for nested mdiobus
> read/write calls, nested code was introduced in mv88e6xxx and
> mdio-mux.
> But mv88e6060 also needs such nested mdiobus read/write calls.
> For sake of refactoring, introduce nested variants of mdiobus read/write
> and make them used by mv88e6xxx and mv88e6060.
> In a next patch, mdio-mux should also use these variant calls.
>
> Neil Armstrong (3):
> net: phy: Add nested variants of mdiobus read/write
> net: dsa: Make mv88e6xxx use nested mdiobus read/write
> net: dsa: Make mv88e6060 use nested mdiobus read/write
>
> drivers/net/dsa/mv88e6060.c | 4 ++--
> drivers/net/dsa/mv88e6xxx.c | 46 ++++++++-----------------------------
> drivers/net/phy/mdio_bus.c | 55 +++++++++++++++++++++++++++++++++++++++++++++
> include/linux/phy.h | 2 ++
> 4 files changed, 68 insertions(+), 39 deletions(-)
Hi Neil
Thanks for refactoring.
Reviewd-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Andrew Lunn <andrew@lunn.ch>
I tested with a 88E6172 and lockdep enabled.
Thanks
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] Refactor nested mdiobus read/write functions
2015-10-22 8:37 [PATCH 0/3] Refactor nested mdiobus read/write functions Neil Armstrong
2015-10-22 13:18 ` Andrew Lunn
@ 2015-10-23 13:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-10-23 13:00 UTC (permalink / raw)
To: narmstrong
Cc: f.fainelli, linux, vivien.didelot, andrew, fabf, pavel.nakonechny,
joe, netdev, linux-kernel, nbd, sergei.shtylyov
From: Neil Armstrong <narmstrong@baylibre.com>
Date: Thu, 22 Oct 2015 10:37:45 +0200
> In order to avoid locked signal false positive for nested mdiobus
> read/write calls, nested code was introduced in mv88e6xxx and
> mdio-mux.
> But mv88e6060 also needs such nested mdiobus read/write calls.
> For sake of refactoring, introduce nested variants of mdiobus read/write
> and make them used by mv88e6xxx and mv88e6060.
> In a next patch, mdio-mux should also use these variant calls.
Series applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-23 12:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-22 8:37 [PATCH 0/3] Refactor nested mdiobus read/write functions Neil Armstrong
2015-10-22 13:18 ` Andrew Lunn
2015-10-23 13:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).