From: Joe Jin <joe.jin@oracle.com>
To: boris.ostrovsky@oracle.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH 1/1] xen-netfront: limit max queues number to online cpus
Date: Fri, 23 Oct 2015 15:19:32 +0800 [thread overview]
Message-ID: <5629DF84.70201@oracle.com> (raw)
In-Reply-To: <5629846B.8000001@oracle.com>
We need to take care sysfs too, please ignore this patch, I'll create
new one later for review and comment.
Thanks,
Joe
On 10/23/2015 08:50 AM, Joe Jin wrote:
> Should not allocate queues number more than online cpus.
>
> Signed-off-by: Joe Jin <joe.jin@oracle.com>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: David S. Miller <davem@davemloft.net>
> ---
> drivers/net/xen-netfront.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index f821a97..1eebd4e 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -2137,7 +2137,7 @@ static int __init netif_init(void)
> /* Allow as many queues as there are CPUs if user has not
> * specified a value.
> */
> - if (xennet_max_queues == 0)
> + if (xennet_max_queues == 0 || xennet_max_queues > num_online_cpus())
> xennet_max_queues = num_online_cpus();
>
> return xenbus_register_frontend(&netfront_driver);
>
prev parent reply other threads:[~2015-10-23 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 0:50 [PATCH 1/1] xen-netfront: limit max queues number to online cpus Joe Jin
2015-10-23 7:19 ` Joe Jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5629DF84.70201@oracle.com \
--to=joe.jin@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).