From: Joe Jin <joe.jin@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Campbell <ian.campbell@citrix.com>,
wei.liu2@citrix.com, "David S. Miller" <davem@davemloft.net>,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH V2 2/2] xen-netfront: limit vnic max_queues number to online cpus
Date: Fri, 23 Oct 2015 17:39:32 +0800 [thread overview]
Message-ID: <562A0054.1030200@oracle.com> (raw)
In-Reply-To: <562A1A6E02000078000ADEFB@prv-mh.provo.novell.com>
On 10/23/2015 05:30 PM, Jan Beulich wrote:
>>>> On 23.10.15 at 11:19, <joe.jin@oracle.com> wrote:
>>
>> @@ -164,6 +166,19 @@ struct netfront_rx_info {
>> struct xen_netif_extra_info extras[XEN_NETIF_EXTRA_TYPE_MAX - 1];
>> };
>>
>> +static int xennet_set_max_queues(const char *val, struct kernel_param *kp)
>> +{
>> + unsigned int cpus = num_online_cpus();
>> + unsigned int max_queues = simple_strtoul(val, NULL, 10);
>> +
>> + if (max_queues == 0 || max_queues > cpus) {
>> + pr_err("max_queues %u is out of range [0 - %u]!\n",
>
> I suppose you mean "...[1 - %u]!\n" here?
Yes you are right, you catch my fault again :)
Thanks so much, will resend new later.
Regards,
Joe
> Jan
>
--
Oracle <http://www.oracle.com>
Joe Jin | Software Development Director | +8610.6106.5624
ORACLE | Linux and Virtualization
No. 24 Zhongguancun Software Park, Haidian District | 100193 Beijing
prev parent reply other threads:[~2015-10-23 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 9:17 [PATCH V2 0/2] limit xen vnic max queues number to online cpus number Joe Jin
2015-10-23 9:18 ` [PATCH V2 1/2] xen-netback: limit xen vif max queues number to online cpus Joe Jin
2015-10-23 9:19 ` [PATCH V2 2/2] xen-netfront: limit vnic max_queues " Joe Jin
2015-10-23 9:30 ` Jan Beulich
2015-10-23 9:39 ` Joe Jin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562A0054.1030200@oracle.com \
--to=joe.jin@oracle.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).