From: Masashi Honma <masashi.honma@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6 route: Aggregate table getting code
Date: Sun, 25 Oct 2015 11:42:19 +0900 [thread overview]
Message-ID: <562C418B.9050909@gmail.com> (raw)
In-Reply-To: <20151018.230913.533343373986091178.davem@davemloft.net>
On 2015/10/19 15:09, David Miller wrote:
> This is not correct.
>
> The whole point of the test is so that the kernel log message
> warning for failing to provide NLM_F_CREATE can be printed
> in precisely the correct conditions.
Thanks. Now I understand importance of the warning.
Though fib6_get_table() is called twice to show the warning.
So I made another patch to reduce calling the function.
next prev parent reply other threads:[~2015-10-25 2:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 0:51 [PATCH] ipv6 route: Aggregate table getting code Masashi Honma
2015-10-19 6:09 ` David Miller
2015-10-25 2:42 ` Masashi Honma [this message]
2015-10-25 2:44 ` [PATCH] ipv6 route: Use flag instead of calling fib6_get_table() twice Masashi Honma
2015-10-27 5:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562C418B.9050909@gmail.com \
--to=masashi.honma@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).