netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <alexander.duyck@gmail.com>
Subject: Re: [PATCH net] amd-xgbe: Fix race between access of desc and desc index
Date: Wed, 28 Oct 2015 08:48:36 -0500	[thread overview]
Message-ID: <5630D234.3070600@amd.com> (raw)
In-Reply-To: <20151027.195007.1435133435434786670.davem@davemloft.net>

On 10/27/2015 09:50 PM, David Miller wrote:
> From: Tom Lendacky <thomas.lendacky@amd.com>
> Date: Mon, 26 Oct 2015 17:13:54 -0500
>
>> During Tx cleanup it's still possible for the descriptor data to be
>> read ahead of the descriptor index. A memory barrier is required between
>> the read of the descriptor index and the start of the Tx cleanup loop.
>> This allows a change to a lighter-weight barrier in the Tx transmit
>> routine just before updating the current descriptor index.
>>
>> Since the memory barrier does result in extra overhead on arm64, keep
>> the previous change to not chase the current descriptor value. This
>> prevents the execution of the barrier for each loop performed.
>>
>> Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> Applied, thanks.
>

Thanks David.  Could you queue this up for the 4.1 and 4.2 stable
trees?

Thanks,
Tom

  reply	other threads:[~2015-10-28 13:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 22:13 [PATCH net] amd-xgbe: Fix race between access of desc and desc index Tom Lendacky
2015-10-28  2:50 ` David Miller
2015-10-28 13:48   ` Tom Lendacky [this message]
2015-11-01 17:04     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5630D234.3070600@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).