From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [RFC PATCH v3 1/5] net: dsa: allow switch drivers to cleanup their resources Date: Thu, 29 Oct 2015 15:56:28 +0100 Message-ID: <5632339C.8000302@baylibre.com> References: <56323104.2030606@baylibre.com> <20151029145052.GU2307@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Florian Fainelli , Guenter Roeck , vivien.didelot@savoirfairelinux.com, Fabian Frederick , Pavel Nakonechny , Joe Perches , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Lunn Return-path: In-Reply-To: <20151029145052.GU2307@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/29/2015 03:50 PM, Andrew Lunn wrote: > On Thu, Oct 29, 2015 at 03:45:24PM +0100, Neil Armstrong wrote: >> --- a/net/dsa/dsa.c >> +++ b/net/dsa/dsa.c >> @@ -459,6 +459,10 @@ static void dsa_switch_destroy(struct dsa_switch *ds) >> } >> >> mdiobus_unregister(ds->slave_mii_bus); >> + >> + /* Leave a chance to the driver to cleanup */ >> + if (ds->drv->remove) >> + ds->drv->remove(ds); >> } > > https://lkml.org/lkml/2015/10/28/532 ??? > > Andrew > Well, sorry, I did the change but it got lost when refactoring the ppu stuff. Neil